Skip to content

wayland: Print table split when DMABuf format changes

Colin Kinloch requested to merge ColinKinloch/gstreamer:wl_modifier_rule into main

The zwp_linux_dmabuf_v1 doesn't specify an order for modifier events to be sent.

In my case the linear format was sent last resulting in the first item in each row being the previous format.

main:

+--- All DMA Formats With Modifiers -----+
| Gst Format   | DRM Format              |
|              | AR24:0x020000001046bb04 |
|              | AR24:0x0200000010467b04 |
|              | AR24:0x0200000010437b04 |
|              | AR24:0x0200000010401b04 |
|              | AR24:0x0200000000000a04 |
|-----------------------------------------
| BGRA         | AR24                    |
|              | AB24:0x020000001046bb04 |
|              | AB24:0x0200000010467b04 |
|              | AB24:0x0200000010437b04 |
|              | AB24:0x0200000010401b04 |
|              | AB24:0x0200000000000a04 |
|-----------------------------------------

With this MR:

+--- All DMA Formats With Modifiers -----+
| Gst Format   | DRM Format              |
|-----------------------------------------
|              | AR24:0x020000001046bb04 |
|              | AR24:0x0200000010467b04 |
|              | AR24:0x0200000010437b04 |
|              | AR24:0x0200000010401b04 |
|              | AR24:0x0200000000000a04 |
| BGRA         | AR24                    |
|-----------------------------------------
|              | AB24:0x020000001046bb04 |
|              | AB24:0x0200000010467b04 |
|              | AB24:0x0200000010437b04 |
|              | AB24:0x0200000010401b04 |
|              | AB24:0x0200000000000a04 |
| RGBA         | AB24                    |
|-----------------------------------------

The worst case scenario for this code would be the compositor sending formats in a random order, printing row delimiter for every item, which I guess would be fine.

Edited by Tim-Philipp Müller

Merge request reports