Skip to content

matroskademux: header parsing fixes

Tim-Philipp Müller requested to merge tpm/gstreamer:sec-matroska-combined into main

List

  • matroskademux: Only unmap GstMapInfo in WavPack header extraction error paths if previously mapped
  • matroskademux: Check for big enough WavPack codec private data before accessing it
  • matroskademux: Don't take data out of an empty adapter when processing WavPack frames
  • matroskademux: Skip over zero-sized Xiph stream headers
  • matroskademux: Put a copy of the codec data into the A_MS/ACM caps

matroskademux: Only unmap GstMapInfo in WavPack header extraction error paths if previously mapped

Thanks to Antonio Morales for finding and reporting the issue.

Fixes GHSL-2024-197

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3863

matroskademux: Check for big enough WavPack codec private data before accessing it

Thanks to Antonio Morales for finding and reporting the issue.

Fixes GHSL-2024-250

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3866

matroskademux: Don't take data out of an empty adapter when processing WavPack frames

Thanks to Antonio Morales for finding and reporting the issue.

Fixes GHSL-2024-249

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3865

matroskademux: Skip over zero-sized Xiph stream headers

Thanks to Antonio Morales for finding and reporting the issue.

Fixes GHSL-2024-251

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3867

matroskademux: Put a copy of the codec data into the A_MS/ACM caps

The original codec data buffer is owned by matroskademux and does not necessarily live as long as the caps.

Thanks to Antonio Morales for finding and reporting the issue.

Fixes GHSL-2024-280

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3894

Merge request reports