Skip to content

A couple of fixes for flaky unit test

Jan Schmidt requested to merge thaytan/gstreamer:webrtcbin-more-stats-fixes into main

commit bf4c46444332f59944120d1f6d2d39b0a41ba97a Author: Jan Schmidt jan@centricular.com Date: Tue Aug 20 19:20:34 2024 +1000

webrtc: Fix racy unit test

Don't reuse the same stats state structure across multiple
get-stats calls. Make each callback take a copy of the
non-changing fields it needs and use a local working copy
to avoid crashing.

Fixes problems with the unit test crashing sometimes for the
unit test introduced in MR !7338

commit ce0616ee05f36fb9ffed4c7da1b776a826d32fb9 Author: Jan Schmidt jan@centricular.com Date: Tue Aug 20 18:57:50 2024 +1000

webrtcbin: Always populate rtp-inbound stats fields

Even if there's no jitterbuffer yet for an incoming stream,
make sure to populate the mandatory statistics with 0 entries.

Fixes problems with the unit test failing sometimes for the
unit test introduced in MR !7338

Merge request reports