Skip to content

Revert "base: videosink: Avoid positing message on the bus before being constructed"

Tim-Philipp Müller requested to merge tpm/gstreamer:videosink-revert-set-properties-in-constructed into main

This reverts commit 893e4ed0.

This caused regressions in existing elements which override/set things like QoS and such in their own init functions. If the base class does this in ::constructed() now it will override the subclass settings again with its own, which can have unintended side-effects.

Case in point is gdkpixbufsink which disabled QoS there, and this patch would reliably make the unit test fail in valgrind because now frames are dropped because of QoS (when QoS should really be disabled).

Fixes #2794

Merge request reports