Skip to content

Fix compiler warnings and a leak in qroverlay related to g_string_free(s, FALSE)

Tim-Philipp Müller requested to merge tpm/gstreamer:g_string_free_return_val into main

Newer GLib (>= 2.76) seems to warn if the return value of g_string_free(s, FALSE) doesn't get used, see cerbero!1149 (comment 1840121)

gitlint: allow commas and spaces in commit message prefix
e.g. "foo, bar: did stuff" should be allowed
taglist, plugins: fix compiler warnings with GLib >= 2.76
Fix compiler warnings about not using the return value when
freeing the GString segment with g_string_free(.., FALSE):

    ignoring return value of ‘g_string_free_and_steal’ declared with attribute ‘warn_unused_result’

which we get with newer GLib versions. These were all harmless.
debugqroverlay: fix string leak
g_string_free(.., FALSE) gives us ownership of the string
already, no need to duplicate that again with g_strdup(),
and doing so will leak the string returned by g_string_free()
here. Caught by compiler warnings in newer GLib versions.

Merge request reports