Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 929
    • Issues 929
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 443
    • Merge requests 443
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Merge requests
  • !33

baseparse: Use buffer from short reads instead of pulling again

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged KimTaeSoo requested to merge myrandy1/gstreamer:master into master Nov 14, 2018
  • Overview 33
  • Commits 2
  • Pipelines 2
  • Changes 2

When "num-buffers" property of basesrc is set, the last buffer cannot be pushed. baseparse tries buffer pulling to get the buffer with 64KB from gstbasesrc and a parser element makes the buffer of right pulling size and calculates the right offset. When baseparse tries buffer pulling in case of the last buffer, the size of buffer is lesser than original pulling size. So gstbaseparse buffer pulling again to get the buffer with the remaining size. Because of this behavior, gst_base_src_get_range() for the last buffer is called twice.

#294 (closed)

Edited Nov 14, 2018 by Sebastian Dröge
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master