Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 750
    • Issues 750
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 383
    • Merge requests 383
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gstreamergstreamer
  • Merge requests
  • !2175

tsdemux: Fix AC-4 detection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Edward Hervey requested to merge bilboed/gstreamer:ac4-regression into main Apr 14, 2022
  • Overview 1
  • Commits 1
  • Pipelines 3
  • Changes 2

This regression was introduced by gst-plugins-bad!1102 (merged) and has been present since 1.18

  • Stream Type 0x06 is defined in the base mpeg-ts specification as Private PES Packets. Determining the content should be solely based on descriptors found within the PMT.
  • This was abused in that commit by defining a "bluray-only" stream type for AC4 : ST_BD_AUDIO_AC4
  • This should be entirely handled in the regular private pes handling further down in the code

Fixes #1154 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ac4-regression