Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 680
    • Issues 680
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 353
    • Merge requests 353
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gstreamergstreamer
  • Merge requests
  • !1527

Merged
Created Jan 15, 2022 by Tomasz Andrzejak@andreiltdContributor

sdpmessage: fix mapping single char fmtp params

  • Overview 5
  • Commits 2
  • Pipelines 5
  • Changes 2

This fixes mapping of single character parameters from SDP to caps as discussed here: gst-plugins-rs!626 (comment 1218849)

E.g. for following a=fmtp:110 raptor-scheme-id=1; Kmax=8192; T=128; P=A; repair-window=200000 the caps will miss T and P

  • Before patch:
caps: application/x-rtp, media=(string)application, payload=(int)110, clock-rate=(int)90000, encoding-name=(string)RAPTORFEC, raptor-scheme-id=(string)1, kmax=(string)8192, repair-window=(string)200000
  • After patch:
caps: application/x-rtp, media=(string)application, payload=(int)110, clock-rate=(int)90000, encoding-name=(string)RAPTORFEC, raptor-scheme-id=(string)1, kmax=(string)8192, t=(string)128, p=(string)A, repair-window=(string)200000

To reproduce try following launch line (sdp file attatched below):

GST_DEBUG=2,sdpdemux:9 gst-launch-1.0 -v filesrc location=raptorq.sdp ! sdpdemux ! fakesink

raptorq.sdp

Edited Jan 15, 2022 by Tomasz Andrzejak
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: sdpmessage