Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.1k
    • Issues 1.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 499
    • Merge requests 499
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Merge requests
  • !1123

audio aggregator: Remove never triggered condition

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Olivier Crête requested to merge ocrete/gstreamer:gst-plugins-base-audio-agg-remove-dead-code into main Oct 12, 2021
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

Copied from https://gitlab.freedesktop.org//gstreamer/gst-plugins-base/-/merge_requests/1178

At this point, there is a buffer, which means that there is some data left in it. But we've read all that is in there. So we're certain that the next byte written from that buffer will be after the current output offset.

Add a g_assert() just to be safe

This came from my attempt to write a unit test to trigger this code. But I don't think it's possible.

Please review this MR very very very carefully because I may have missed something.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gst-plugins-base-audio-agg-remove-dead-code