Skip to content

smartencoder: Fix some regressions introduced while cleaning up negotiation

Thibault Saunier requested to merge thiblahute/gstreamer:smartvp8 into main 
commit b7c994b5d85ee49866400ddba366db3bdf58e684 (HEAD -> smartvp8, thiblahute/smartvp8)
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Tue Oct 5 12:28:22 2021 -0300

    qtmux: Allow more fields changes renegotiating h264
    
    And consider interlace-mode=progress as equivalent to the field not
    being specified.

commit fe4fbbf963d42a80f27a5eff093ab996c7e4fab0
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Tue Oct 5 10:50:32 2021 -0300

    matroskamux: Ignore some fields when renegotiating
    
    Those values are never used in the muxer so we should not fail the
    negotiation if those are changing.

commit c729310b351b28a152f43b87294529c1549a215b
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Tue Oct 5 10:46:26 2021 -0300

    smartencoder: Fix renegotiating when reencoding parts of the stream with vpx
    
    In the encoded streams we might not have all the information about the
    raw video stream, but when reencoding they end up being specified, even
    if those are default values.
    
    As vp8 decoders always output frames in some YUV color space we can
    ensure that when upstream doesn't specify any value in its caps we
    use the default one which is what we end up doing when decoding/reencoding
    anyway, so this way downstream (matroskamux in that case) doesn't need
    to be able to renegotiate (which it doesn't).

Related MR: gst-plugins-base!1249 (merged)

Merge request reports