Follow-up from "rtpmanager: implement SMPTE 2022-1 FEC decoder and encoder"
The following discussion from gst-plugins-good!753 (merged) should be addressed:
-
@ystreet started a discussion: -
If
fec_decoder
already exists, this attempts to link the fec decoder tortpssrcdemux
directly. If there is another ssrc in the rtp session, the fec decoder is already linked to another pad fromrtpptdemux
/rtpjitterbuffer
which then obviously fails. -
This assumes that the fec decoder has an interface where there is a single "sink" pad. However elsewhere in this patch, you request a "fec_%u" pad.
-
- There is also the problem that the fec usage in the linked MR assumes that there is only a single ssrc for a single rtp session. This breaks down extremely fast when dealing with bundled streams or simulcast streams which have any number of ssrc's within the exact same rtp session.
cc @meh