Skip to content

va: regression: vapostproc rotation 90/270 wrong output

vapostproc rotation at 90/270 degrees (video-direction) no longer works correctly since commit b53446dd (!1109 (merged))

Previously a 90/270 rotation resulted in swapped dimensions and rotated image (i.e. WxH -> HxW). Now the rotation outputs image rotated but in original WxH scaled output.

export LIBVA_DRIVER_NAME=iHD
gst-launch-1.0 -vf videotestsrc ! video/x-raw,format=NV12,width=1280,height=720 \
 ! vapostproc  video-direction=90r ! video/x-raw,format=NV12 ! vaapisink
commit b53446ddc9a9bdb8ee9a7e7d8c506f15385c823b (HEAD -> main)
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Tue Oct 5 20:15:09 2021 +0200

    vapostproc: Simplify fixate.
    
    The first approach to fixate was simply a copy&paste of both
    videoconvert and videoscale, trying to keep their logic as isolated
    as possible. But that brought duplicated and sparse logic.
    
    This patch merge both approaches simplifying the fixate operation.
    
    Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>