Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 676
    • Issues 676
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 352
    • Merge requests 352
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gstreamergstreamer
  • Issues
  • #524

Closed
Open
Created Mar 21, 2020 by Ondřej Hruška@MightyPork

Segfault in `gst_date_time_new_local_time()` with illegal date

If the gst_date_time_new_local_time function is called with a date that is out of bounds but otherwise appears valid, such as 2020-02-31, gstreamer segfaults. This is caused by the naïve safety checks at the top of the function.

The crash presumably occurs at https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/master/gst/gstdatetime.c#L571 when NULL is dereferenced.

You could say this causes denial of service.

Affected (that I know of):

  • lollypop
  • clementine
  • strawberry
  • epiphany (if an affected file is in a web page)
  • midori (same)

Basically any player that tries to display date (perhaps from ID3 tags) using this function.

A solution would be to add a NULL check before the affected line.

References:

  • https://gitlab.gnome.org/World/lollypop/issues/2252#note_746298
  • https://bugs.archlinux.org/task/65918

Version:

  • 1.16.2-1 on Arch Linux
Edited Mar 22, 2020 by Ondřej Hruška
Assignee
Assign to
Time tracking