Tiny typo, RFC6501 vs RFC6051
The functionality added in !2132 (merged) is almost always named correctly, but two files contain transposed digits.
- RFC6051 Rapid Synchronisation of RTP Flows
- RFC6501 Conference Information Data Model for Centralized Conferencing
Fix is shown below. (Apply with git apply temp.diff
- or sed -i 's/RFC6501/RFC6051/' subprojects/gst-plugins-good/docs/gst_plugins_cache.json; sed -i 's/RFC6501/RFC6051/' subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-ntp.c
)
p.s. any chance we could get an example gst-launch-1.0
command line to demo the new RFC6051 functionality? I couldn't figure it out myself...
diff --git a/subprojects/gst-plugins-good/docs/gst_plugins_cache.json b/subprojects/gst-plugins-good/docs/gst_plugins_cache.json
index 2adc3e9504..f80e9b1344 100644
--- a/subprojects/gst-plugins-good/docs/gst_plugins_cache.json
+++ b/subprojects/gst-plugins-good/docs/gst_plugins_cache.json
@@ -18443,7 +18443,7 @@
"rtphdrextntp64": {
"RTP-Header-Extension-URI": "urn:ietf:params:rtp-hdrext:ntp-64",
"author": "Sebastian Dröge <sebastian@centricular.com>",
- "description": "Extends RTP packets to add or retrieve a 64-bit NTP timestamp as specified in RFC6501",
+ "description": "Extends RTP packets to add or retrieve a 64-bit NTP timestamp as specified in RFC6051",
"hierarchy": [
"GstRTPHeaderExtensionNtp64",
"GstRTPHeaderExtension",
diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-ntp.c b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-ntp.c
index a027138d5b..2d514f2c7b 100644
--- a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-ntp.c
+++ b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtphdrext-ntp.c
@@ -254,7 +254,7 @@ static void
"RTP Header Extension RFC6051 64-bit NTP timestamp",
GST_RTP_HDREXT_ELEMENT_CLASS,
"Extends RTP packets to add or retrieve a 64-bit NTP "
- "timestamp as specified in RFC6501",
+ "timestamp as specified in RFC6051",
"Sebastian Dröge <sebastian@centricular.com>");
gst_rtp_header_extension_class_set_uri (rtp_hdr_class,
GST_RTP_HDREXT_BASE GST_RTP_HDREXT_NTP_64);