Skip to content

GitLab

gstreamer
gstreamer
Open
Opened by Bugzilla Migration User@bugzilla-migration
Report abuse New issue

baseparse: invalid timestamps in pull mode

Submitted by Arnaud Vrac @rawoul

Link to original bug (#690152)

Description

Created attachment 231465
Attempt to fix timestamp issues

Commit 75189608 makes baseparse output invalid timestamps in some cases. For example a lot of buffers are dropped when playing this file:

http://streams.videolan.org/samples/Matroska/120fps-mkv/%5bKTKJ%5d%5bstratos4_advance%5d%5b01%5d%5bbig5%5d%5bE72C0C1D%5d.mkv

Before this commit timestamps were also wrong when only DTS was set on input buffers.

I have attached a few files:

  • a patch that attempts to correctly fix the issue (it needs review, I'm not sure of all the implications of the change)

  • logs to demonstrate the timestamp issues. The logs show the timestamps after parsing and decoding of an AVI/MPEG4 video. Before the faulty commit and my patch, video and audio sync was off after some time in push mode. With my patch it works fine in both pull and push modes, timestamps are the same.

Patch 231465, "Attempt to fix timestamp issues":
0001-baseparse-fix-invalid-output-timestamps-in-some-case.patch