Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 717
    • Issues 717
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 372
    • Merge requests 372
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gstreamergstreamer
  • Issues
  • #278
Closed
Open
Created Mar 09, 2018 by Bugzilla Migration User@bugzilla-migration

segment: Change back gst_segment_do_seek() to use gint64

Submitted by Nicolas Dufresne @ndufresne

Link to original bug (#794215)

Description

During 0.11 dev at commit bdbc0693 the gst_segment_do_seek() was changed to accept only unsigned start/stop. Though, the code will do direct comparision with -1 and also assumes negative values for GST_SEEK_TYPE_END:

start = segment->duration + start;

Additionally, the gst_event_new_seek() API along with the GstElement API uses signed integer. Demuxers will pass these value unchecked to that API in order to update their segment. Looking at the code, it will properly wrap around resulting in the same behaviour, but it's all a bit of a lie. As this does not affect the API, I think it's fine to switch it back to gint64.

Assignee
Assign to
Time tracking