Sebastian Dröge authored Jun 23, 2021 and GStreamer Marge Bot committed Sep 22, 2021

Part-of: <!841>

These might not exist inside the structure and then we would potentially
keep around uninitialized memory from the caller in the out parameter.

Part-of: <!887>

Part-of: <!886>

We should record the ownership of the data before we reset the bitwriter.
Or we will always dup the buffer data and leak the memory.

Part-of: <!886>

In reset_and_get_data and reset_and_get_buffer, it fails to include
the trailing bits less than 8. So, when the bit_size is not byte
aligned, the trailing bits are lost in the return buffer.

Part-of: <!886>

Mathieu Duponchelle authored Sep 10, 2021 and GStreamer Marge Bot committed Sep 13, 2021

The initial single queue srcresult is OK, it hasn't been
NOT_LINKED since 2007.

Part-of: <!885>

Mathieu Duponchelle authored Sep 09, 2021 and GStreamer Marge Bot committed Sep 13, 2021

.. when computing the high id.

After a flush for instance, sq->srcresult is reset to OK,
yet it doesn't make sense to pick a non-existing position
id as the high id when a queue doesn't contain any items
in that situation either.

It is in any case completely OK to let the not-linked stream
get consumed without throttling at this stage, as any
first packet arriving on other single queues will get assigned
a higher position id.

Part-of: <!885>

Part-of: <!884>

Use gap events to update the next_time of a queue the same
as buffers or segment events. Fixes problems where a group
consisting only of sparse streams primarily driven by
gap events would stall with a full multiqueue because
unlinked streams in the group were not being woken to
push data.

Part-of: <!879>

Matthew Waters authored Aug 27, 2021 and GStreamer Marge Bot committed Aug 27, 2021

If dispose() is called more than once, we may double unref the list of
GstContext's.

Part-of: <!875>

When the probe returns GST_PAD_PROBE_REMOVE and gets called concurrently
from the streaming thread while we're in the callback here, the hook has
already been destroyed by the time we've reacquired the object lock.
Consequently, cleanup_hook gets passed an invalid pointer.

Keep another reference to the hook alive to avoid this situation.

Part-of: <!873>

Edward Hervey authored Aug 20, 2021 and Edward Hervey committed Aug 20, 2021

Was broken by !819

Part-of: <!871>

Théo MAILLART authored Jan 10, 2021 and GStreamer Marge Bot committed Aug 20, 2021

Part-of: <!736>

Théo MAILLART authored Jan 29, 2021 and GStreamer Marge Bot committed Aug 20, 2021

Part-of: <!736>

This new tracer will list loaded elements and plugins. This should
make it easier to generate minimal builds of GStreamer.

This also traces other features such as typefind functions, device
providers and dynamic types.

The format of the output of gst-stats should match the parameters
expected by the meson based gst-build system.

Part-of: <!782>

This makes it possible to trace which ones are loaded in a specific
program to make nice statistics.

Part-of: <!782>

Edward Hervey authored Aug 18, 2021 and Edward Hervey committed Aug 18, 2021

The last flow return field was never updated on sink pads in push mode. This
fixes it and makes it consistent.

Part-of: <!868>

This was added in !826 which was created after !803 (which changes
g_memdup -> g_memdup2), but merged before it, so it slipped through.

Part-of: <!866>

We shouldn't fail to load plugins just because we don't
recognise the license string. It's not our job to validate
licenses, and the license list is outdated and ambiguous
anyway.

Also add MPL-2.0 to the list, and fix some defunct license
URLs in the code comments.

Get rid of the hard-coded skip index, doesn't really buy us
much versus just skipping with a few strlens, and is harder
to maintain.

Part-of: <!864>

Stéphane Cerveau authored Aug 02, 2021 and GStreamer Marge Bot committed Aug 03, 2021

In order to not rely only on app to display the
message from identity, display the message in the logs
too.

Part-of: <!863>

To use macros in math.h, one needs to define _USE_MATH_DEFINES
before including the math.h file. Use glib's math define instead.

Part-of: <!862>

Default timer precision of Windows is dependent on system, but
usually it's known to be about 15ms in worst case.
That's not an enough precision for multimedia application.

Enable high-resolution clock in gst-launch to demonstrate
the usage of Windows high-precision clock for application developers.

Part-of: <!817>

Jan Alexander Steffens authored Jul 23, 2021 and GStreamer Marge Bot committed Jul 28, 2021

We need to use the segment associated with the cached buffer, not the
current segment of the pad, otherwise we miscalculate the running time
of cached buffers from before a segment change.

Part-of: <!859>

Stéphane Cerveau authored Jul 20, 2021 and GStreamer Marge Bot committed Jul 26, 2021

Finetune the bug description.

Part-of: <!854>

Zhao Gang authored May 09, 2021 and GStreamer Marge Bot committed Jul 26, 2021

GError should be set if function call failed and the failed reason is
not a programmer error.

Fixed: gst-plugins-bad#1380
Part-of: <!816>

Zhao Gang authored May 09, 2021 and GStreamer Marge Bot committed Jul 26, 2021

Normally uri is get from user input and invalid user input should not
be treated as critical error. Moved gst_uri_is_valid outside of
g_return_val_if_fail.

NULL uri is checked inside of gst_uri_is_valid and is correctly
treated as critical error, removed unneeded checks of NULL uri outside
of gst_uri_is_valid function.

Part-of: <!816>

Seungha Yang authored Jul 20, 2021 and GStreamer Marge Bot committed Jul 26, 2021

Before the MR !829
Windows and macOS system clock used monotonic clock regardless of
selected clock mode. And because of clock resolution, we should prefer
monotonic over realtime unless realtime clock is selected explicitly.

Part-of: <!855>

Step handling is implemented based on unmodified start/stop
segment running time, and basesink takes rate into account for
stepping. This commit is partially undoing new behavior introduced by
the commit of 39b9cc55 when stepping.

Part-of: <!848>

Nirbheek Chauhan authored Jul 19, 2021 and GStreamer Marge Bot committed Jul 19, 2021

120 bytes in 5 blocks are definitely lost in loss record 7,615 of 9,510
   at 0x484486F: malloc (vg_replace_malloc.c:380)
   by 0x58A2938: g_malloc (gmem.c:106)
   by 0x58BA1F4: g_slice_alloc (gslice.c:1069)
   by 0x588F059: g_list_prepend (glist.c:335)
   by 0x5B9C5C0: select_best_master_clock (gstptpclock.c:756)
   by 0x5B9CA8E: cleanup_cb (gstptpclock.c:1930)
   by 0x589AD20: g_timeout_dispatch (gmain.c:4889)
   by 0x589A4CE: UnknownInlinedFun (gmain.c:3337)
   by 0x589A4CE: g_main_context_dispatch (gmain.c:4055)
   by 0x58EE4E7: g_main_context_iterate.constprop.0 (gmain.c:4131)
   by 0x5899A92: g_main_loop_run (gmain.c:4329)
   by 0x5B9BA4C: ptp_helper_main (gstptpclock.c:1980)
   by 0x58C8C31: g_thread_proxy (gthread.c:826)

576 bytes in 24 blocks are definitely lost in loss record 8,782 of 9,510
   at 0x484486F: malloc (vg_replace_malloc.c:380)
   by 0x58A2938: g_malloc (gmem.c:106)
   by 0x58BA1F4: g_slice_alloc (gslice.c:1069)
   by 0x588F059: g_list_prepend (glist.c:335)
   by 0x5B9C5C0: select_best_master_clock (gstptpclock.c:756)
   by 0x5B9EFA0: handle_announce_message (gstptpclock.c:934)
   by 0x5B9EFA0: handle_ptp_message (gstptpclock.c:1765)
   by 0x5B9EFA0: have_stdin_data_cb (gstptpclock.c:1851)
   by 0x589A4CE: UnknownInlinedFun (gmain.c:3337)
   by 0x589A4CE: g_main_context_dispatch (gmain.c:4055)
   by 0x58EE4E7: g_main_context_iterate.constprop.0 (gmain.c:4131)
   by 0x5899A92: g_main_loop_run (gmain.c:4329)
   by 0x5B9BA4C: ptp_helper_main (gstptpclock.c:1980)
   by 0x58C8C31: g_thread_proxy (gthread.c:826)
   by 0x5DA4298: start_thread (pthread_create.c:481)

Part-of: <!852>

This is being logged for each buffer, so it should not use INFO.

Part-of: <!853>

To clarify what is expected in an issue description and avoid
issue which is just an usage issue, add a bug template in gitlab.

Part-of: <!836>

Part-of: <!849>

Edward Hervey authored May 28, 2020 and Edward Hervey committed Jul 05, 2021

When getting backtraces, we were always creating a new Dwfl context and then
discarding it. The problem with that is that it resulted in having to re-scan a
lot of information for every single backtrace.

In order to fix that issue, use a global on-demand Dwfl context and use it with
a lock.

Furthermore, we were scanning the mappings of the
process (dwfl_linux_proc_report) for *every single step* in the backtrace, and
that function is horrendously expensive (does sscanf on /proc/PID/maps
...). While there is a possibility that new mappings might be available (new
plugins being loaded for example), we can limit ourselves to just do it once per
backtrace.

These two modifications speed up the elements_leaks unit test (which traces all
pads with full backtraces) by a factor of 6.

Partially fixes #567

Part-of: <!504>

Fix "has no handler with id" output criticals when the :
multilink operator is used. These were caused by disconnecting
a signal handler multiple times.

Part-of: <!846>

Usually the latency message is only posted whenever latency of an
element changes but that might be too early as the sinks might not be
able to query the latency at that point yet.

Similarly adding a new sink should cause latency reconfiguration once
that new sink is able to report its latency.

This fixes latency configuration in pipelines where webrtcbin is the
only "sink", i.e. it is used in a sendonly session. Before, the latency
would always be configured to 0.

Part-of: <!843>

Sebastian Dröge authored Jun 24, 2021 and GStreamer Marge Bot committed Jun 24, 2021

Part-of: <!842>

Part-of: <!840>

Corentin Damman authored Jun 15, 2021 and GStreamer Marge Bot committed Jun 21, 2021

Part-of: <!835>

Jan Schmidt authored Jun 09, 2021 and GStreamer Marge Bot committed Jun 21, 2021

If a property is supplied to gst-launch-1.0 to set on a property that
implements GstChildProxy, it would always accept any property name
and try to set it later. This means that (for example) decodebin
will accept and not complain about property names that can never exist like:

gst-launch-1.0 videotestsrc ! decodebin NON-EXISTING_PROPERTY=adsfdasf ! fakesink

Instead, only try to do deferred property setting for property names
that contain the :: separator that indicates it's a setting on a child
that might appear later.

Part-of: <!832>