1. 02 Feb, 2022 2 commits
  2. 28 Jan, 2022 2 commits
  3. 20 Jan, 2022 2 commits
  4. 17 Jan, 2022 1 commit
  5. 31 Oct, 2021 2 commits
    • hacpa's avatar
      baseparse: fix invalid avg_bitrate after reset · f263bdcb
      hacpa authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      gst_base_parse_reset() does not reset data_bytecount to 0, so
      gst_base_parse_update_bitrates() uses a wrong value to calculate
      the average bitrate on subsequent pipeline starts. This leads to an
      excessive amount of "tag" events being pushed. These events include
      very high "bitrate" values that diminish over time, and are produced
      until the average bitrate is back to sane values.
      
      Fixes #840
      
      Part-of: <!1285>
      f263bdcb
    • Jan Alexander Steffens's avatar
      multiqueue: Fix query unref race on flush · 516f9592
      Jan Alexander Steffens authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      If the query has already been destroyed at this point, GST_IS_QUERY will
      read garbage, can return false and we will try to unref it again.
      Instead, make note of whether the item is a query when we dequeue it.
      
      Part-of: <!1284>
      516f9592
  6. 29 Oct, 2021 7 commits
  7. 08 Sep, 2021 3 commits
  8. 06 Sep, 2021 2 commits
  9. 27 Aug, 2021 1 commit
  10. 24 Aug, 2021 1 commit
    • Jan Alexander Steffens's avatar
      pad: Keep IDLE probe hook alive during immediate callback · e0a3af02
      Jan Alexander Steffens authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      When the probe returns GST_PAD_PROBE_REMOVE and gets called concurrently
      from the streaming thread while we're in the callback here, the hook has
      already been destroyed by the time we've reacquired the object lock.
      Consequently, cleanup_hook gets passed an invalid pointer.
      
      Keep another reference to the hook alive to avoid this situation.
      
      Part-of: <!874>
      e0a3af02
  11. 23 Aug, 2021 1 commit
  12. 20 Aug, 2021 1 commit
  13. 18 Aug, 2021 1 commit
  14. 11 Aug, 2021 1 commit
  15. 22 Jul, 2021 3 commits
    • Seungha Yang's avatar
      basesink: Don't swap rstart/rstop when stepping · 0a63363f
      Seungha Yang authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      Step handling is implemented based on unmodified start/stop
      segment running time, and basesink takes rate into account for
      stepping. This commit is partially undoing new behavior introduced by
      the commit of 39b9cc55 when stepping.
      
      Part-of: <!858>
      0a63363f
    • Nirbheek Chauhan's avatar
      gstptpclock: Don't leak the GList · 49ae75f2
      Nirbheek Chauhan authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      120 bytes in 5 blocks are definitely lost in loss record 7,615 of 9,510
         at 0x484486F: malloc (vg_replace_malloc.c:380)
         by 0x58A2938: g_malloc (gmem.c:106)
         by 0x58BA1F4: g_slice_alloc (gslice.c:1069)
         by 0x588F059: g_list_prepend (glist.c:335)
         by 0x5B9C5C0: select_best_master_clock (gstptpclock.c:756)
         by 0x5B9CA8E: cleanup_cb (gstptpclock.c:1930)
         by 0x589AD20: g_timeout_dispatch (gmain.c:4889)
         by 0x589A4CE: UnknownInlinedFun (gmain.c:3337)
         by 0x589A4CE: g_main_context_dispatch (gmain.c:4055)
         by 0x58EE4E7: g_main_context_iterate.constprop.0 (gmain.c:4131)
         by 0x5899A92: g_main_loop_run (gmain.c:4329)
         by 0x5B9BA4C: ptp_helper_main (gstptpclock.c:1980)
         by 0x58C8C31: g_thread_proxy (gthread.c:826)
      
      576 bytes in 24 blocks are definitely lost in loss record 8,782 of 9,510
         at 0x484486F: malloc (vg_replace_malloc.c:380)
         by 0x58A2938: g_malloc (gmem.c:106)
         by 0x58BA1F4: g_slice_alloc (gslice.c:1069)
         by 0x588F059: g_list_prepend (glist.c:335)
         by 0x5B9C5C0: select_best_master_clock (gstptpclock.c:756)
         by 0x5B9EFA0: handle_announce_message (gstptpclock.c:934)
         by 0x5B9EFA0: handle_ptp_message (gstptpclock.c:1765)
         by 0x5B9EFA0: have_stdin_data_cb (gstptpclock.c:1851)
         by 0x589A4CE: UnknownInlinedFun (gmain.c:3337)
         by 0x589A4CE: g_main_context_dispatch (gmain.c:4055)
         by 0x58EE4E7: g_main_context_iterate.constprop.0 (gmain.c:4131)
         by 0x5899A92: g_main_loop_run (gmain.c:4329)
         by 0x5B9BA4C: ptp_helper_main (gstptpclock.c:1980)
         by 0x58C8C31: g_thread_proxy (gthread.c:826)
         by 0x5DA4298: start_thread (pthread_create.c:481)
      
      Part-of: <!857>
      49ae75f2
    • Nirbheek Chauhan's avatar
      gstpad: Don't spam INFO when default-chaining a buffer list · bbbf0c10
      Nirbheek Chauhan authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      This is being logged for each buffer, so it should not use INFO.
      
      Part-of: <!856>
      bbbf0c10
  16. 08 Jul, 2021 1 commit
  17. 24 Jun, 2021 1 commit
  18. 11 Jun, 2021 1 commit
  19. 14 May, 2021 5 commits
  20. 06 May, 2021 1 commit
  21. 20 Apr, 2021 1 commit
    • Miguel París Díaz's avatar
      pad: clear probes holding mutex · 0d1fad0e
      Miguel París Díaz authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Protect clearing probes against concurrent modification which might happen
      due to dispose does NOT guarantee that the object is not used anymore, as
      it could be referenced again and so being continued used.
      So, as in the rest of places where probes hook list is used, on dispose
      it should be accessed holding the mutex "GST_OBJECT_LOCK (pad);" as
      GHookList is not thread-safe.
      
      Part-of: <!800>
      0d1fad0e