Commit e243a411 authored by Stefan Kost's avatar Stefan Kost
Browse files

gstelementfactory: set object name earlier if applicable

Setting an object name is nice for proper debug logging. Ideally this would
still happens earlier (.e.g when pads are added to an element, its not yet set).
parent 076aeeb7
......@@ -405,7 +405,13 @@ gst_element_factory_create (GstElementFactory * factory, const gchar * name)
if (factory->type == 0)
goto no_type;
/* create an instance of the element, cast so we don't assert on NULL */
/* create an instance of the element, cast so we don't assert on NULL
* also set name as early as we can
*/
if (name)
element =
GST_ELEMENT_CAST (g_object_new (factory->type, "name", name, NULL));
else
element = GST_ELEMENT_CAST (g_object_newv (factory->type, 0, NULL));
if (G_UNLIKELY (element == NULL))
goto no_element;
......@@ -420,9 +426,6 @@ gst_element_factory_create (GstElementFactory * factory, const gchar * name)
(gpointer) & oclass->elementfactory, NULL, factory))
gst_object_unref (factory);
if (name)
gst_object_set_name (GST_OBJECT_CAST (element), name);
GST_DEBUG ("created element \"%s\"", GST_PLUGIN_FEATURE_NAME (factory));
return element;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment