Commit b2b16109 authored by Sebastian Dröge's avatar Sebastian Dröge 🍵 Committed by GStreamer Marge Bot
Browse files

aggregator: Hold SRC_LOCK while unblocking via SRC_BROADCAST()

Otherwise the clock id we access might not be a valid pointer anymore.

Part-of: <!656>
parent 30151e6f
Pipeline #209169 waiting for manual action with stages
in 38 seconds
......@@ -1837,7 +1837,9 @@ gst_aggregator_change_state (GstElement * element, GstStateChange transition)
case GST_STATE_CHANGE_PAUSED_TO_PLAYING:
/* Wake up any waiting as now we have a clock and can do
* proper waiting on the clock if necessary */
SRC_LOCK (self);
SRC_BROADCAST (self);
SRC_UNLOCK (self);
break;
default:
break;
......@@ -1859,7 +1861,9 @@ gst_aggregator_change_state (GstElement * element, GstStateChange transition)
case GST_STATE_CHANGE_PLAYING_TO_PAUSED:
/* Wake up any waiting as now clock might be gone and we might
* need to wait on the condition variable again */
SRC_LOCK (self);
SRC_BROADCAST (self);
SRC_UNLOCK (self);
break;
default:
break;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment