Commit 90beb712 authored by Antonio Ospite's avatar Antonio Ospite

gst-inspect: fix printing the first field of a GstStructure

When printing a GstStructure property (e.g. the "stats" property in
rtpsession) the first field is printed on the same line of the type
description, and this is both inconsistent compared to  how Enum values
are printed and confusing as the reader might miss the first field.

To fix this, add a newline before printing GstStructure fields in

NOTE: this does not change the existing inconsistent behavior of an
extra newline *after* a GstStructure property, but the latter is not as
annoying and it would take more effort to fix because GstStructure
fields are printed in CAPS descriptions too.
parent 2fa15d53
Pipeline #28569 passed with stages
in 55 minutes and 25 seconds
......@@ -636,9 +636,11 @@ print_object_properties_info (GObject * obj, GObjectClass * obj_class,
g_type_name (param->value_type), RESET_COLOR);
if (param->value_type == GST_TYPE_STRUCTURE) {
const GstStructure *s = gst_value_get_structure (&value);
if (s)
if (s) {
g_print ("\n");
gst_structure_foreach (s, print_field,
(gpointer) " ");
} else if (G_IS_PARAM_SPEC_POINTER (param)) {
if (param->value_type != G_TYPE_POINTER) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment