Commit 8dd2b4b5 authored by David Schleef's avatar David Schleef
Browse files

Fix locking in gst_param_spec_is_mutable

parent dd3c9ab6
...@@ -212,7 +212,9 @@ gst_param_spec_fraction (const gchar * name, const gchar * nick, ...@@ -212,7 +212,9 @@ gst_param_spec_fraction (const gchar * name, const gchar * nick,
* @element: the GstElement of the property to be modified * @element: the GstElement of the property to be modified
* *
* Checks if an object property for the GstElement given in @element * Checks if an object property for the GstElement given in @element
* may be modified given the current state of @element. * may be modified given the current state of @element. In order to
* avoid races, this function should be called with the object lock
* of @element held.
* *
* Note: By the time this method returns, the state of the element might have * Note: By the time this method returns, the state of the element might have
* changed already. Use this method only if you can control the state of the * changed already. Use this method only if you can control the state of the
...@@ -233,7 +235,6 @@ gst_param_spec_is_mutable (GParamSpec * param_spec, GstElement * element) ...@@ -233,7 +235,6 @@ gst_param_spec_is_mutable (GParamSpec * param_spec, GstElement * element)
return TRUE; return TRUE;
} }
GST_OBJECT_LOCK (element);
state = GST_STATE (element); state = GST_STATE (element);
if (param_spec->flags & GST_PARAM_MUTABLE_PAUSED) { if (param_spec->flags & GST_PARAM_MUTABLE_PAUSED) {
if (state > GST_STATE_PAUSED) { if (state > GST_STATE_PAUSED) {
...@@ -248,7 +249,6 @@ gst_param_spec_is_mutable (GParamSpec * param_spec, GstElement * element) ...@@ -248,7 +249,6 @@ gst_param_spec_is_mutable (GParamSpec * param_spec, GstElement * element)
ret = FALSE; ret = FALSE;
} }
} }
GST_OBJECT_UNLOCK (element);
return ret; return ret;
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment