From 619dfc91bb4629baf880f7507c42d98cb0f14334 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Thu, 21 Mar 2019 18:47:04 +1100 Subject: [PATCH] aggregator: take the pad lock around queue gap event removal As is done for every other queue interaction --- libs/gst/base/gstaggregator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libs/gst/base/gstaggregator.c b/libs/gst/base/gstaggregator.c index 7fff0f71d6..bc8c05f40a 100644 --- a/libs/gst/base/gstaggregator.c +++ b/libs/gst/base/gstaggregator.c @@ -1499,8 +1499,10 @@ gst_aggregator_default_sink_event (GstAggregator * self, GST_BUFFER_FLAG_SET (gapbuf, GST_BUFFER_FLAG_DROPPABLE); /* Remove GAP event so we can replace it with the buffer */ + PAD_LOCK (aggpad); if (g_queue_peek_tail (&aggpad->priv->data) == event) gst_event_unref (g_queue_pop_tail (&aggpad->priv->data)); + PAD_UNLOCK (aggpad); if (gst_aggregator_pad_chain_internal (self, aggpad, gapbuf, FALSE) != GST_FLOW_OK) { -- GitLab