Commit 13f80412 authored by Tim-Philipp Müller's avatar Tim-Philipp Müller
Browse files

basesink: fix once-per-second 'emergency rendering' for case where all buffers...

basesink: fix once-per-second 'emergency rendering' for case where all buffers but the very first are late

Due to a typo basesink didn't do any emergency rendering of late buffers
if the only buffer ever rendered was the first one with timestamp 0. This
means that in cases where the decoder is very very slow, we'd never see
any buffers but the very first one rendered. Fixes #576381.
parent cf4387d1
......@@ -2232,7 +2232,7 @@ gst_base_sink_is_too_late (GstBaseSink * basesink, GstMiniObject * obj,
GST_TIME_ARGS (max_lateness));
/* !!emergency!!, if we did not receive anything valid for more than a
* second, render it anyway so the user sees something */
if (priv->last_in_time && start - priv->last_in_time > GST_SECOND) {
if (priv->last_in_time != -1 && start - priv->last_in_time > GST_SECOND) {
late = FALSE;
GST_DEBUG_OBJECT (basesink,
"**emergency** last buffer at %" GST_TIME_FORMAT " > GST_SECOND",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment