vaapi: gobjectify internal classes

Submitted by Víctor Manuel Jáquez Leal @vjaquez

Link to original bug (#796308)

Description

gobjectivy internal decoder class and its derivate classes

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Patch 372297, "libs: decoder: refactor decoders as gobject":
libs-decoder-refactor-decoders-as-gobject.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Patch 372298, "libs: decoder: remove gst_vaapi_decoder_new()":
libs-decoder-remove-gstvaapidecodernew.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Patch 372299, "libs: decoder: remove gst_vaapi_decoder_ref()":
libs-decoder-remove-gstvaapidecoderref.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Replaced by gst_object_unref() in tests

Patch 372300, "libs: decoder: remove gst_vaapi_decoder_unref()":
libs-decoder-remove-gstvaapidecoderunref.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Patch 372301, "libs: decoder: h264: remove create() and destroy() callbacks":
libs-decoder-h264-remove-create-and-destroy-callba.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

and remove create() and destroy()
and use g_clear_pointer for dpb structure

Patch 372302, "libs: decoder: h265: implement reset() callback":
libs-decoder-h265-implement-reset-callback.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

and remove create() and destroy() callbacks.

Patch 372304, "libs: decoder: jpeg: implement reset() callback":
libs-decoder-jpeg-implement-reset-callback.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

remove create() and destroy() callbacks

Patch 372305, "libs: decoder: mpeg2: implement reset() callback":
libs-decoder-mpeg2-implement-reset-callback.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

remove destroy() and create() callback

Patch 372306, "libs: decoder: mpeg4: implement reset() callback":
libs-decoder-mpeg4-implement-reset-callback.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

remove destroy() and create() callbacks

use g_clear_pointer for rbdu_buffer

no cast for enum

Patch 372307, "libs: decoder: vc1: implement reset() callback":
libs-decoder-vc1-implement-reset-callback.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

remove create() and destroy() callbacks

Patch 372308, "libs: decoder: vp8: implement reset() callback":
libs-decoder-vp8-implement-reset-callback.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

remove destroy() and create() callback

Patch 372309, "libs: decoder: vp9: implement reset() callback":
libs-decoder-vp9-implement-reset-callback.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

They were all replaced by reset()

Patch 372310, "libs: decoder: remove destoy() and create() callbacks":
libs-decoder-remove-destoy-and-create-callbacks.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Patch 372338, "libs: filter: refactor filter as gobject":
libs-filter-refactor-filter-as-gobject.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Replacing them by gst_object_ref() and gst_object_unref()

Patch 372339, "libs: filters: remove custom ref() and unref()":
libs-filters-remove-custom-ref-and-unref.patch

Víctor Manuel Jáquez Leal @vjaquez submitted a patch:

Replacing them by gst_object_ref() and gst_object_unref()

Patch 372340, "libs: filter: remove custom ref() and unref()":
libs-filter-remove-custom-ref-and-unref.patch

Sreerenj Balachandran @sree said:

Do you have any benchmarking results to share?; memory footprint when replacing gstvaapiminiobject with gstobject?

Víctor Manuel Jáquez Leal @vjaquez said:

(In reply to sreerenj from comment 17)

Do you have any benchmarking results to share?; memory footprint when
replacing gstvaapiminiobject with gstobject?

Nope. Though they would nice to have. I look for it.

Still, these patches changes only affects to the internal decoder and filter (next will the encoders). Decoders and encoders only exists one per element (1:1 mapping), in the case of the filter it may be used in other elements. And I thing that GstObject offer more tooling (such as leak tracing).

Another story would be surfaces and buffers, where they might be replaces with GstMiniObject, but that other story for now.

Víctor Manuel Jáquez Leal @vjaquez said:

Ok... Finally I devoted some time to do a simple benchmark using valgrind's massif tool.

The test program launches 4 videos to be rendered with a vaapisink in drm (headless).

After initialization, with and without the patches, the memory consumption is similar: ~17.5M in total.

Nonetheless, the peaks at initialization are significantly different:

WITHOUT these patches 47.14M
WITH these patches 44M

Víctor Manuel Jáquez Leal @vjaquez committed some patches:

Attachment 372297 pushed as 0ca49a10 - libs: decoder: refactor decoders as gobject
Attachment 372298 pushed as a75329ca - libs: decoder: remove gst_vaapi_decoder_new()
Attachment 372299 pushed as ad5eb751 - libs: decoder: remove gst_vaapi_decoder_ref()
Attachment 372300 pushed as 4649ac1c - libs: decoder: remove gst_vaapi_decoder_unref()
Attachment 372301 pushed as 7a9f7f09 - libs: decoder: h264: remove create() and destroy() callbacks
Attachment 372302 pushed as 3dbddfa6 - libs: decoder: h265: implement reset() callback
Attachment 372304 pushed as c1d65cf1 - libs: decoder: jpeg: implement reset() callback
Attachment 372305 pushed as 0374a8c0 - libs: decoder: mpeg2: implement reset() callback
Attachment 372306 pushed as 5b3f6eb2 - libs: decoder: mpeg4: implement reset() callback
Attachment 372307 pushed as 2b207a47 - libs: decoder: vc1: implement reset() callback
Attachment 372308 pushed as e4934203 - libs: decoder: vp8: implement reset() callback
Attachment 372309 pushed as 60dad9fa - libs: decoder: vp9: implement reset() callback
Attachment 372310 pushed as a2f923f9 - libs: decoder: remove destoy() and create() callbacks
Attachment 372338 pushed as 99183e01 - libs: filter: refactor filter as gobject
Attachment 372340 pushed as ae46b1a9 - libs: filter: remove custom ref() and unref()