Skip to content

regression: postproc: can't negotiate DMABuf downstream

I just notice that master cannot negotiates playback with glimagesink anymore.

GST_GL_PLATFORM=egl GST_GL_WINDOW=wayland gst-play-1.0 video.mp4  --videosink=glimagesink

I did a bisect and found out that the guilty commit is

commit ca2942176b5632e07eebac23336954f9aaf1cb26
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date:   Tue Nov 12 12:21:52 2019 -0800

    plugins: base: manage pad-specific data in a single struct
    
    Define a struct (GstVaapiPadPrivate) to encapsulate the
    pad-specific data (i.e. buffer pool, allocator, info,
    caps, etc.).
    
    Add an interface to retrieve the data struct for a given
    pad.
    
    Finally, update the base plugin to use the data struct
    throughout the implementation.
    
    This will enable us to easily extend the base plugin in the
    future to allow for N-to-1 pad subclasses (e.g. overlay/
    composite).

 gst/vaapi/gstvaapipluginbase.c | 254 ++++++++++++++++++++++++++---------------
 gst/vaapi/gstvaapipluginbase.h |  59 ++++++----
 2 files changed, 194 insertions(+), 119 deletions(-)

CC: @ullysses.a.eoff