.gitlab-ci.yml

@@ -137,12 +137,12 @@ clippy:
           FEATURES=v1_16
         fi
 
-        cargo clippy --color=always --manifest-path $crate/Cargo.toml --features=$FEATURES -- -A clippy::redundant_pattern_matching -A clippy::single_match -A clippy::cast_lossless
+        cargo clippy --color=always --manifest-path $crate/Cargo.toml --features=$FEATURES --all-targets -- -A clippy::redundant_pattern_matching -A clippy::single_match -A clippy::cast_lossless -A clippy::missing_safety_doc
       done
     # And also run over all the examples/tutorials
     - |
-      cargo clippy --color=always --manifest-path examples/Cargo.toml --bins --examples --all-features -- -A clippy::redundant_pattern_matching -A clippy::single_match -A clippy::cast_lossless
-      cargo clippy --color=always --manifest-path tutorials/Cargo.toml --bins --examples --all-features -- -A clippy::redundant_pattern_matching -A clippy::single_match -A clippy::cast_lossless
+      cargo clippy --color=always --manifest-path examples/Cargo.toml --all-targets --all-features -- -A clippy::redundant_pattern_matching -A clippy::single_match -A clippy::cast_lossless -A clippy::missing_safety_doc
+      cargo clippy --color=always --manifest-path tutorials/Cargo.toml --all-targets --all-features -- -A clippy::redundant_pattern_matching -A clippy::single_match -A clippy::cast_lossless -A clippy::missing_safety_doc
 
 audit:
   extends: '.tarball_setup'

examples/src/bin/appsink.rs

@@ -168,7 +168,7 @@ fn main_loop(pipeline: gst::Pipeline) -> Result<(), Error> {
                         .map(|s| String::from(s.get_path_string()))
                         .unwrap_or_else(|| String::from("None")),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

examples/src/bin/appsrc.rs

@@ -160,7 +160,7 @@ fn main_loop(pipeline: gst::Pipeline) -> Result<(), Error> {
                         .map(|s| String::from(s.get_path_string()))
                         .unwrap_or_else(|| String::from("None")),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

examples/src/bin/decodebin.rs

@@ -281,7 +281,7 @@ fn example_main() -> Result<(), Error> {
                                 .map(|s| String::from(s.get_path_string()))
                                 .unwrap_or_else(|| String::from("None")),
                             error: err.get_error().description().into(),
-                            debug: Some(err.get_debug().unwrap().to_string()),
+                            debug: err.get_debug(),
                             cause: err.get_error(),
                         }
                         .into()),
@@ -295,7 +295,7 @@ fn example_main() -> Result<(), Error> {
                             .map(|s| String::from(s.get_path_string()))
                             .unwrap_or_else(|| String::from("None")),
                         error: err.get_error().description().into(),
-                        debug: Some(err.get_debug().unwrap().to_string()),
+                        debug: err.get_debug(),
                         cause: err.get_error(),
                     }
                     .into());

examples/src/bin/encodebin.rs

@@ -311,7 +311,7 @@ fn example_main() -> Result<(), Error> {
                                 .map(|s| String::from(s.get_path_string()))
                                 .unwrap_or_else(|| String::from("None")),
                             error: err.get_error().description().into(),
-                            debug: Some(err.get_debug().unwrap().to_string()),
+                            debug: err.get_debug(),
                             cause: err.get_error(),
                         }
                         .into()),
@@ -325,7 +325,7 @@ fn example_main() -> Result<(), Error> {
                             .map(|s| String::from(s.get_path_string()))
                             .unwrap_or_else(|| String::from("None")),
                         error: err.get_error().description().into(),
-                        debug: Some(err.get_debug().unwrap().to_string()),
+                        debug: err.get_debug(),
                         cause: err.get_error(),
                     }
                     .into());

examples/src/bin/glupload.rs

@@ -594,7 +594,7 @@ impl App {
                             .map(|s| String::from(s.get_path_string()))
                             .unwrap_or_else(|| String::from("None")),
                         error: err.get_error().description().into(),
-                        debug: Some(err.get_debug().unwrap().to_string()),
+                        debug: err.get_debug(),
                         cause: err.get_error(),
                     }
                     .into());

examples/src/bin/gtkvideooverlay.rs

@@ -144,7 +144,6 @@ fn create_ui(app: &gtk::Application) {
     // simplifies the code within the callback. What this actually does, however, is creating
     // a memory leak.
     let video_overlay = sink
-        .clone()
         .dynamic_cast::<gst_video::VideoOverlay>()
         .unwrap()
         .downgrade();

examples/src/bin/pango-cairo.rs

@@ -213,7 +213,6 @@ fn create_pipeline() -> Result<gst::Pipeline, Error> {
         })
         .unwrap();
 
-    let drawer_clone = drawer.clone();
     // Add a signal handler to the overlay's "caps-changed" signal. This could e.g.
     // be called when the sink that we render to does not support resizing the image
     // itself - but the user just changed the window-size. The element after the overlay
@@ -226,7 +225,6 @@ fn create_pipeline() -> Result<gst::Pipeline, Error> {
             let _overlay = args[0].get::<gst::Element>().unwrap().unwrap();
             let caps = args[1].get::<gst::Caps>().unwrap().unwrap();
 
-            let drawer = &drawer_clone;
             let mut drawer = drawer.lock().unwrap();
             drawer.info = Some(gst_video::VideoInfo::from_caps(&caps).unwrap());
 
@@ -257,7 +255,7 @@ fn main_loop(pipeline: gst::Pipeline) -> Result<(), Error> {
                         .map(|s| String::from(s.get_path_string()))
                         .unwrap_or_else(|| String::from("None")),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

examples/src/bin/rtpfecclient.rs

@@ -275,7 +275,7 @@ fn example_main() -> Result<(), Error> {
                         .map(|s| String::from(s.get_path_string()))
                         .unwrap_or_else(|| String::from("None")),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

examples/src/bin/rtpfecserver.rs

@@ -146,9 +146,8 @@ fn example_main() -> Result<(), Error> {
     let sinkpad = get_static_pad(&sink, "sink")?;
     srcpad.link(&sinkpad)?;
 
-    let convclone = conv.clone();
-    src.connect_pad_added(move |decodebin, src_pad| {
-        match connect_decodebin_pad(&src_pad, &convclone) {
+    src.connect_pad_added(
+        move |decodebin, src_pad| match connect_decodebin_pad(&src_pad, &conv) {
             Ok(_) => (),
             Err(err) => {
                 gst_element_error!(
@@ -158,8 +157,8 @@ fn example_main() -> Result<(), Error> {
                     ["{}", err]
                 );
             }
-        }
-    });
+        },
+    );
 
     let video_caps = gst::Caps::new_simple("video/x-raw", &[]);
 
@@ -199,7 +198,7 @@ fn example_main() -> Result<(), Error> {
                         .map(|s| String::from(s.get_path_string()))
                         .unwrap_or_else(|| String::from("None")),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

examples/src/bin/subclass.rs

@@ -385,7 +385,7 @@ fn main_loop(pipeline: gst::Pipeline) -> Result<(), Error> {
                         .map(|s| String::from(s.get_path_string()))
                         .unwrap_or_else(|| String::from("None")),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

examples/src/bin/tagsetter.rs

@@ -109,7 +109,7 @@ fn example_main() -> Result<(), Error> {
                         .unwrap_or_else(|| "None".into())
                         .to_string(),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

examples/src/bin/transmux.rs

@@ -175,7 +175,7 @@ fn example_main() -> Result<(), Error> {
                         .map(|s| String::from(s.get_path_string()))
                         .unwrap_or_else(|| String::from("None")),
                     error: err.get_error().description().into(),
-                    debug: Some(err.get_debug().unwrap().to_string()),
+                    debug: err.get_debug(),
                     cause: err.get_error(),
                 }
                 .into());

gstreamer-app/CHANGELOG.md

@@ -5,6 +5,27 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html),
 specifically the [variant used by Rust](http://doc.crates.io/manifest.html#the-version-field).
 
+## [0.15.1] - 2020-01-23
+### Added
+- Use static inner lifetime for `VideoCodecState<Readable>` so that it can be
+  stored safely on the heap.
+- Getters/setters for `BinFlags` on `gst::Bin`.
+- `gst::Caps::builder_full()` for building caps with multiple structures
+  conveniently.
+- `gst::Element::call_async_future()` for asynchronously spawning a closure
+  and returning a `Future` for awaiting its return value.
+
+### Fixed
+- Various clippy warnings.
+- Getters/setters for `PadFlags` on `gst::Pad` now provide the correct
+  behaviour.
+- Take mutex before popping messages in the `gst::Bus` `Stream` to close a
+  small race condition that could cause it to not be woken up.
+- `gst::ChildProxy` implementers do not have to provide `child_added()` and
+  `child_removed()` functions anymore but these are optional now.
+- Manually implement `Debug` impls for various generic types where to `Debug`
+  impl should not depend on their type parameters also implementing `Debug`.
+
 ## [0.15.0] - 2019-12-18
 ### Added
 - `StructureRef::get_optional()` for returning `None` if the field does not

gstreamer-app/Cargo.toml

 [package]
 name = "gstreamer-app"
-version = "0.15.0"
+version = "0.15.1"
 authors = ["Sebastian Dröge <sebastian@centricular.com>"]
 categories = ["api-bindings", "multimedia"]
 description = "Rust bindings for GStreamer App library"

gstreamer-audio/CHANGELOG.md

@@ -5,6 +5,27 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html),
 specifically the [variant used by Rust](http://doc.crates.io/manifest.html#the-version-field).
 
+## [0.15.1] - 2020-01-23
+### Added
+- Use static inner lifetime for `VideoCodecState<Readable>` so that it can be
+  stored safely on the heap.
+- Getters/setters for `BinFlags` on `gst::Bin`.
+- `gst::Caps::builder_full()` for building caps with multiple structures
+  conveniently.
+- `gst::Element::call_async_future()` for asynchronously spawning a closure
+  and returning a `Future` for awaiting its return value.
+
+### Fixed
+- Various clippy warnings.
+- Getters/setters for `PadFlags` on `gst::Pad` now provide the correct
+  behaviour.
+- Take mutex before popping messages in the `gst::Bus` `Stream` to close a
+  small race condition that could cause it to not be woken up.
+- `gst::ChildProxy` implementers do not have to provide `child_added()` and
+  `child_removed()` functions anymore but these are optional now.
+- Manually implement `Debug` impls for various generic types where to `Debug`
+  impl should not depend on their type parameters also implementing `Debug`.
+
 ## [0.15.0] - 2019-12-18
 ### Added
 - `StructureRef::get_optional()` for returning `None` if the field does not

gstreamer-audio/Cargo.toml

 [package]
 name = "gstreamer-audio"
-version = "0.15.0"
+version = "0.15.1"
 authors = ["Sebastian Dröge <sebastian@centricular.com>"]
 categories = ["api-bindings", "multimedia"]
 description = "Rust bindings for GStreamer Audio library"

gstreamer-base/CHANGELOG.md

@@ -5,6 +5,27 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html),
 specifically the [variant used by Rust](http://doc.crates.io/manifest.html#the-version-field).
 
+## [0.15.1] - 2020-01-23
+### Added
+- Use static inner lifetime for `VideoCodecState<Readable>` so that it can be
+  stored safely on the heap.
+- Getters/setters for `BinFlags` on `gst::Bin`.
+- `gst::Caps::builder_full()` for building caps with multiple structures
+  conveniently.
+- `gst::Element::call_async_future()` for asynchronously spawning a closure
+  and returning a `Future` for awaiting its return value.
+
+### Fixed
+- Various clippy warnings.
+- Getters/setters for `PadFlags` on `gst::Pad` now provide the correct
+  behaviour.
+- Take mutex before popping messages in the `gst::Bus` `Stream` to close a
+  small race condition that could cause it to not be woken up.
+- `gst::ChildProxy` implementers do not have to provide `child_added()` and
+  `child_removed()` functions anymore but these are optional now.
+- Manually implement `Debug` impls for various generic types where to `Debug`
+  impl should not depend on their type parameters also implementing `Debug`.
+
 ## [0.15.0] - 2019-12-18
 ### Added
 - `StructureRef::get_optional()` for returning `None` if the field does not

gstreamer-base/Cargo.toml

 [package]
 name = "gstreamer-base"
-version = "0.15.0"
+version = "0.15.1"
 authors = ["Sebastian Dröge <sebastian@centricular.com>"]
 categories = ["api-bindings", "multimedia"]
 description = "Rust bindings for GStreamer Base library"

gstreamer-check/CHANGELOG.md

@@ -5,6 +5,27 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html),
 specifically the [variant used by Rust](http://doc.crates.io/manifest.html#the-version-field).
 
+## [0.15.1] - 2020-01-23
+### Added
+- Use static inner lifetime for `VideoCodecState<Readable>` so that it can be
+  stored safely on the heap.
+- Getters/setters for `BinFlags` on `gst::Bin`.
+- `gst::Caps::builder_full()` for building caps with multiple structures
+  conveniently.
+- `gst::Element::call_async_future()` for asynchronously spawning a closure
+  and returning a `Future` for awaiting its return value.
+
+### Fixed
+- Various clippy warnings.
+- Getters/setters for `PadFlags` on `gst::Pad` now provide the correct
+  behaviour.
+- Take mutex before popping messages in the `gst::Bus` `Stream` to close a
+  small race condition that could cause it to not be woken up.
+- `gst::ChildProxy` implementers do not have to provide `child_added()` and
+  `child_removed()` functions anymore but these are optional now.
+- Manually implement `Debug` impls for various generic types where to `Debug`
+  impl should not depend on their type parameters also implementing `Debug`.
+
 ## [0.15.0] - 2019-12-18
 ### Added
 - `StructureRef::get_optional()` for returning `None` if the field does not