Tests are broken

Rust: " { S8, U8, S16LE, S16BE, U16LE, U16BE, S24_32LE, S24_32BE, U24_32LE, U24_32BE, S32LE, S32BE, U32LE, U32BE, S24LE, S24BE, U24LE, U24BE, S20LE, S20BE, U20LE, U20BE, S18LE, S18BE, U18LE, U18BE, F32LE, F32BE, F64LE, F64BE }" C: "{ S8, U8, S16LE, S16BE, U16LE, U16BE, S24_32LE, S24_32BE, U24_32LE, U24_32BE, S32LE, S32BE, U32LE, U32BE, S24LE, S24BE, U24LE, U24BE, S20LE, S20BE, U20LE, U20BE, S18LE, S18BE, U18LE, U18BE, F32LE, F32BE, F64LE, F64BE }"

This one is funny. There's a leading space, and that is removed by get_c_value() from tests/abi.rs (autogenerated from gir). The space is there in the .gir file, the C header, the generated C test file.

So this needs the trimming to be removed, which unfortunately is not ideal either because the trimming was needed for some reason I assume. Needs a bug report against gir in any case.

: error: ‘GST_GL_DISPLAY_EGL_NAME’ undeclared (first use in this function); did you mean ‘GST_GL_DISPLAY_TYPE_NONE’? tests/constant.c:9:22: note: in expansion of macro ‘ABI_CONSTANT_NAME’ printf(_Generic((ABI_CONSTANT_NAME), ^~~~~~~~~~~~~~~~~

This is a bug in GStreamer in one way or another. That constant (and a few others) are added to the .gir file but are not included by the specified header. This constant would require explicit inclusion of gst/gl/egl/gstglmemoryegl.h or gst/gl/egl/gstgldisplay_egl.h. Needs a bug report against GStreamer.

Constant value mismatch for GST_GL_COLOR_CONVERT_VIDEO_CAPS Rust: "video/x-raw(" C: "video/x-raw(memory:GLMemory), format = (string) { RGBA, RGB, RGBx, BGR, BGRx, BGRA, xRGB, xBGR, ARGB, ABGR, Y444, I420, YV12, Y42B, Y41B, NV12, NV21, YUY2, UYVY, AYUV, GRAY8, GRAY16_LE, GRAY16_BE, RGB16, BGR16 }, width = (int) [ 1, max ], height = (int) [ 1, max ], framerate = (fraction) [ 0, max ], texture-target = (string) { 2D, rectangle, external-oes } ; video/x-raw(memory:GLMemory,meta:GstVideoOverlayComposition), format = (string) { RGBA, RGB, RGBx, BGR, BGRx, BGRA, xRGB, xBGR, ARGB, ABGR, Y444, I420, YV12, Y42B, Y41B, NV12, NV21, YUY2, UYVY, AYUV, GRAY8, GRAY16_LE, GRAY16_BE, RGB16, BGR16 }, width = (int) [ 1, max ], height = (int) [ 1, max ], framerate = (fraction) [ 0, max ], texture-target = (string) { 2D, rectangle, external-oes }"

This is a bug in gobject-introspection. It fails to parse the constant from the header correctly. Needs a bug report against gobject-introspection

In gstreamer-sys there are the following known issues

running 2 tests
test cross_validate_layout_with_c ... ok
/usr/bin/ld: /tmp/ccsdDS4p.o: in function `main':
constant.c:(.text+0xe): undefined reference to `g_strerror'
collect2: error: ld returned 1 exit status
test cross_validate_constants_with_c ... FAILED

From GST_ERROR_SYSTEM, which can't really be used outside C. Should get a (skip) annotation in GStreamer, i.e. GStreamer bug.

Constant value mismatch for GST_MESSAGE_ANY
Rust: "4294967295"
C:    "-1"
constants ... 273 passed; 2 failed (compilation errors: 1)
Constant value mismatch for GST_MESSAGE_DEVICE_ADDED
Rust: "2147483649"
C:    "-2147483647"
Constant value mismatch for GST_MESSAGE_DEVICE_REMOVED
Rust: "2147483650"
C:    "-2147483646"
Constant value mismatch for GST_MESSAGE_EXTENDED
Rust: "2147483648"
C:    "-2147483648"
Constant value mismatch for GST_MESSAGE_PROPERTY_NOTIFY
Rust: "2147483651"
C:    "-2147483645"
Constant value mismatch for GST_MESSAGE_REDIRECT
Rust: "2147483654"
C:    "-2147483642"
constants ... 293 passed; 7 failed (compilation errors: 1)
Constant value mismatch for GST_MESSAGE_STREAMS_SELECTED
Rust: "2147483653"
C:    "-2147483643"
Constant value mismatch for GST_MESSAGE_STREAM_COLLECTION
Rust: "2147483652"
C:    "-2147483644"

Mismatch between signed and unsigned values. They are the same in C, but Rust is a bit more picky about it :) See https://github.com/gtk-rs/gir/issues/572. It's not a problem in practice but it breaks the test.

constants ... 416 passed; 9 failed (compilation errors: 1)
Constant value mismatch for GST_PTR_FORMAT
Rust: "paA"
C:    "p\u{7}A"
constants ... 440 passed; 10 failed (compilation errors: 1)
constants ... 465 passed; 10 failed (compilation errors: 1)
constants ... 490 passed; 10 failed (compilation errors: 1)
Constant value mismatch for GST_SEGMENT_FORMAT
Rust: "paB"
C:    "p\u{7}B"
constants ... 514 passed; 11 failed (compilation errors: 1)
Constant value mismatch for GST_STIME_FORMAT
Rust: "c%"
C:    "c%u:%02u:%02u.%09u"

These format specifiers can't really be used from outside C. Needs (skip) annotation in GStreamer, so GStreamer bug. There are also some more of these IIRC.

constants ... 688 passed; 12 failed (compilation errors: 1)
Constant value mismatch for GST_VERSION_MICRO
Rust: "1"
C:    "4"

We shouldn't really test the version defines, or otherwise things will fail when running with a different version than the .gir file. This should simply be ignored on our side via the .toml file. I think there's a mechanism for that. If you can't find it, just let me know.

Created by: alatiera

Here is the summary so far:

Tests that pass:

gstreamer-app-sys
gstreamer-base-sys
gstreamer-net-sys
gstreamer-player-sys
gstreamer-rtsp-sys
gstreamer-tag-sys
gstreamer-video-sys

and tests that fail:

gstreamer-sys: A bunch of (skips) needed. https://bugzilla.gnome.org/show_bug.cgi?id=797320 The mismatch between signed and unsigned as mentioned above https://github.com/gtk-rs/gir/issues/572
gstreamer-audio-sys Fails due to an extra whitespace, filed https://github.com/gtk-rs/gir/issues/644
gstreamer-gl-sys 2 failures here. One is a bug in gobject-introspection (still need to file that). The other is due to this one
gstreamer-pbutils-sys Tries to compare GST_VERSION_MICRO. This needs to be skipped.
gstreamer-sdp-sys

running 2 tests
test cross_validate_layout_with_c ... FAILED
test cross_validate_constants_with_c ... ok

failures:

---- cross_validate_layout_with_c stdout ----
Layout mismatch for GstMIKEYPayloadKeyData
Rust: Layout { size: 112, alignment: 8 }
C:    Layout { size: 128, alignment: 8 }
layout    ... 24 passed; 1 failed (compilation errors: 0)
thread 'cross_validate_layout_with_c' panicked at 'FAILED: 31 passed; 1 failed (compilation errors: 0)', gstreamer-sdp-sys/tests/abi.rs:126:13
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    cross_validate_layout_with_c

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '-p gstreamer-sdp-sys --test abi'

gstreamer-rtsp-server-sys

running 2 tests
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifClient’ undeclared (first use in this function); did you mean ‘GstRTSPClient’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifClientClass’ undeclared (first use in this function); did you mean ‘GstRTSPClientClass’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifMedia’ undeclared (first use in this function); did you mean ‘GstRTSPMedia’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifMediaClass’ undeclared (first use in this function); did you mean ‘GstRTSPMediaClass’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifMediaFactory’ undeclared (first use in this function); did you mean ‘GstRTSPMediaFactory’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifMediaFactoryClass’ undeclared (first use in this function); did you mean ‘GstRTSPMediaFactoryClass’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifServer’ undeclared (first use in this function); did you mean ‘GstRTSPServer’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/layout.c: In function ‘main’:
<command-line>: error: ‘GstRTSPOnvifServerClass’ undeclared (first use in this function); did you mean ‘GstRTSPServerClass’?
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’
     printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME));
                               ^~~~~~~~~~~~~
tests/constant.c: In function ‘main’:
<command-line>: error: ‘GST_RTSP_ONVIF_BACKCHANNEL_REQUIREMENT’ undeclared (first use in this function); did you mean ‘GST_RTSP_STS_PAYMENT_REQUIRED’?
<command-line>: note: in definition of macro ‘ABI_CONSTANT_NAME’
<command-line>: note: each undeclared identifier is reported only once for each function it appears in
<command-line>: note: in definition of macro ‘ABI_CONSTANT_NAME’
test cross_validate_constants_with_c ... FAILED
test cross_validate_layout_with_c ... FAILED

failures:

---- cross_validate_constants_with_c stdout ----
constants ... 25 passed; 0 failed (compilation errors: 0)
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_CONSTANT_NAME=GST_RTSP_ONVIF_BACKCHANNEL_REQUIREMENT" "tests/constant.c" "-o" "/tmp/abi.DAtHvZOfnIS4/constant" failed, exit code: 1
thread 'cross_validate_constants_with_c' panicked at 'FAILED: 41 passed; 1 failed (compilation errors: 1)', gstreamer-rtsp-server-sys/tests/abi.rs:126:13
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- cross_validate_layout_with_c stdout ----
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifClient" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifClientClass" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifMedia" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifMediaClass" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifMediaFactory" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
layout    ... 20 passed; 5 failed (compilation errors: 5)
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifMediaFactoryClass" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifServer" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
compilation command "cc" "-Wno-deprecated-declarations" "-D__USE_MINGW_ANSI_STDIO" "-I/usr/include/gstreamer-1.0" "-I/usr/include/glib-2.0" "-I/usr/lib64/glib-2.0/include" "-pthread" "-DABI_TYPE_NAME=GstRTSPOnvifServerClass" "tests/layout.c" "-o" "/tmp/abi.o9fJk60nOsfs/layout" failed, exit code: 1
layout    ... 42 passed; 8 failed (compilation errors: 8)
thread 'cross_validate_layout_with_c' panicked at 'FAILED: 42 passed; 8 failed (compilation errors: 8)', gstreamer-rtsp-server-sys/tests/abi.rs:126:13


failures:
    cross_validate_constants_with_c
    cross_validate_layout_with_c

test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '-p gstreamer-rtsp-server-sys --test abi'

Currently missing the required deps to test the following:

gstreamer-mpegts-sys
gstreamer-webrtc-sys

Layout mismatch for GstMIKEYPayloadKeyData Rust: Layout { size: 112, alignment: 8 } C: Layout { size: 128, alignment: 8 } layout ... 24 passed; 1 failed (compilation errors: 0) thread 'cross_validate_layout_with_c' panicked at 'FAILED: 31 passed; 1 failed (compilation errors: 0)', gstreamer-sdp-sys/tests/abi.rs:126:13 note: Run with RUST_BACKTRACE=1 for a backtrace.

This is a bug in gir, oh no!

typedef struct {
  [...]
  guint8   kv_len[2];
  guint8  *kv_data[2];
} GstMIKEYPayloadKeyData;

vs.

#[repr(C)]
#[derive(Copy, Clone)]
pub struct GstMIKEYPayloadKeyData {                                                                              
    [...]
    pub kv_len: [u8; 2], 
    pub kv_data: [u8; 2],
}

kv_data should be a [*mut u8; 2] instead. In the .gir file it looks correct, compare with the e.g. salt_data field (which is a *mut u8, not as an array).

tests/layout.c: In function ‘main’: : error: ‘GstRTSPOnvifClient’ undeclared (first use in this function); did you mean ‘GstRTSPClient’? tests/layout.c:10:31: note: in expansion of macro ‘ABI_TYPE_NAME’ printf("%zu\n%zu", sizeof(ABI_TYPE_NAME), alignof(ABI_TYPE_NAME)); ^~~~~~~~~~~~~

This is because you're using GStreamer 1.12 and the gst-rtsp-server headers are not marking the version correctly for all the GstRTSPOnvif types. Bug in GStreamer, they should all get a Since: 1.14 marker.

Currently missing the required deps to test the following:
* gstreamer-mpegts-sys

* gstreamer-webrtc-sys

What do you mean with missing required deps? Not available in Fedora? Both are in gst-plugins-bad, mpegts since a long time and webrtc since version 1.14 (you seem to be using 1.12 so that would be the problem for that one). webrtc has no errors, mpegts has one error.

layout    ... 25 passed; 0 failed (compilation errors: 0)
Layout mismatch for GstMpegtsISO639LanguageDescriptor
Rust: Layout { size: 324, alignment: 4 }
C:    Layout { size: 776, alignment: 8 }

This is a bug in gir again.

#[repr(C)]
#[derive(Copy, Clone)]
pub struct GstMpegtsISO639LanguageDescriptor {                                                                   
    pub nb_language: c_uint,
    pub language: [c_char; 64],
    pub audio_type: [GstMpegtsIso639AudioType; 64],
}

typedef struct _GstMpegtsISO639LanguageDescriptor GstMpegtsISO639LanguageDescriptor;
struct _GstMpegtsISO639LanguageDescriptor                                                                        
{
  guint                    nb_language;
  gchar                    *language[64];
  GstMpegtsIso639AudioType audio_type[64];
};

Basically the same things as in the SDP library. The language field should be a [*mut c_char; 64].

Created by: alatiera

What do you mean with missing required deps? Not available in Fedora? Both are in gst-plugins-bad, mpegts since a long time and webrtc since version 1.14 (you seem to be using 1.12 so that would be the problem for that one). webrtc has no errors, mpegts has one error.

For mpegts I get the following errors recurring thousands of times:

running 2 tests
In file included from tests/manual.h:3,
                 from tests/constant.c:5:
/usr/include/gstreamer-1.0/gst/mpegts/mpegts.h:28:2: warning: #warning "The GStreamer mpegts library is unstable API and may change in future." [-Wcpp]
 #warning "The GStreamer mpegts library is unstable API and may change in future."
  ^~~~~~~
In file included from tests/manual.h:3,
                 from tests/layout.c:5:
/usr/include/gstreamer-1.0/gst/mpegts/mpegts.h:28:2: warning: #warning "The GStreamer mpegts library is unstable API and may change in future." [-Wcpp]
 #warning "The GStreamer mpegts library is unstable API and may change in future."
  ^~~~~~~
/usr/include/gstreamer-1.0/gst/mpegts/mpegts.h:29:2: warning: #warning "You can define GST_USE_UNSTABLE_API to avoid this warning." [-Wcpp]
 #warning "You can define GST_USE_UNSTABLE_API to avoid this warning."
  ^~~~~~~
/usr/include/gstreamer-1.0/gst/mpegts/mpegts.h:29:2: warning: #warning "You can define GST_USE_UNSTABLE_API to avoid this warning." [-Wcpp]
 #warning "You can define GST_USE_UNSTABLE_API to avoid this warning."
  ^~~~~~~
In file included from tests/manual.h:3,
                 from tests/layout.c:5:

and for wertc the following, also recurring:

running 2 tests
In file included from /usr/include/gstreamer-1.0/gst/webrtc/webrtc.h:24,
                 from tests/manual.h:3,
                 from tests/layout.c:5:
/usr/include/gstreamer-1.0/gst/webrtc/webrtc_fwd.h:24:2: warning: #warning "The WebRTC library from gst-plugins-bad is unstable API and may change in future." [-Wcpp]
 #warning "The WebRTC library from gst-plugins-bad is unstable API and may change in future."
  ^~~~~~~
/usr/include/gstreamer-1.0/gst/webrtc/webrtc_fwd.h:25:2: warning: #warning "You can define GST_USE_UNSTABLE_API to avoid this warning." [-Wcpp]
 #warning "You can define GST_USE_UNSTABLE_API to avoid this warning."
  ^~~~~~~
In file included from /usr/include/gstreamer-1.0/gst/webrtc/webrtc.h:24,
                 from tests/manual.h:3,
                 from tests/constant.c:5:
/usr/include/gstreamer-1.0/gst/webrtc/webrtc_fwd.h:24:2: warning: #warning "The WebRTC library from gst-plugins-bad is unstable API and may change in future." [-Wcpp]
 #warning "The WebRTC library from gst-plugins-bad is unstable API and may change in future."
  ^~~~~~~
/usr/include/gstreamer-1.0/gst/webrtc/webrtc_fwd.h:25:2: warning: #warning "You can define GST_USE_UNSTABLE_API to avoid this warning." [-Wcpp]
 #warning "You can define GST_USE_UNSTABLE_API to avoid this warning."
  ^~~~~~~
In file included from /usr/include/gstreamer-1.0/gst/webrtc/webrtc.h:24,
                 from tests/manual.h:3,
                 from tests/layout.c:5:
/usr/include/gstreamer-1.0/gst/webrtc/webrtc_fwd.h:24:2: warning: #warning "The WebRTC library from gst-plugins-bad is unstable API and may change in future." [-Wcpp]
 #warning "The WebRTC library from gst-plugins-bad is unstable API and may change in future."
  ^~~~~~~

This is because you're using GStreamer 1.12 and the gst-rtsp-server headers are not marking the version correctly for all the GstRTSPOnvif types. Bug in GStreamer, they should all get a Since: 1.14 marker.

I am on fedora 28 and gst 1.14

➜  gstreamer-sys git:(master) ✗ sudo dnf info gstreamer1
Last metadata expiration check: 2:02:18 ago on Tue 23 Oct 2018 11:36:20 AM EEST.
Installed Packages
Name         : gstreamer1
Version      : 1.14.1
Release      : 2.fc28
Arch         : x86_64
Size         : 4.2 M
Source       : gstreamer1-1.14.1-2.fc28.src.rpm
Repo         : @System
From repo    : updates
Summary      : GStreamer streaming media framework runtime
URL          : http://gstreamer.freedesktop.org/
License      : LGPLv2+
Description  : GStreamer is a streaming media framework, based on graphs of filters which
             : operate on media data. Applications using this library can do anything
             : from real-time sound processing to playing videos, and just about anything
             : else media-related.  Its plugin-based architecture means that new data
             : types or processing capabilities can be added simply by installing new
             : plugins.

/usr/include/gstreamer-1.0/gst/mpegts/mpegts.h:28:2: warning: #warning "The GStreamer mpegts library is unstable API and may change in future." [-Wcpp] #warning "The GStreamer mpegts library is unstable API and may change in future." ^~~~~~~

These are warnings you can safely ignore. You can #define GST_USE_UNSTABLE_API to prevent that but it does not seem worth it. They're just warnings after all :)

I am on fedora 28 and gst 1.14

Also gst-rtsp-server 1.14? Are the onvif headers not included by gst/rtsp-server/rtsp-server.h then? That would be a bug :)

Did you find the webrtc and mpegts library in the meantime?

The problem about GST_GL_COLOR_CONVERT_VIDEO_CAPS is tracked here now: https://gitlab.gnome.org/GNOME/gobject-introspection/issues/238

Once we have all bugs filed, we should probably create a single comment with all the links :)

Created by: alatiera

To recap:

gstreamer-sys:

Skip some C formatters, Merged.
Mismatch between signed and unsigned integers gtk-rs/gir#572

gstreamer-audio-sys

Fails due to trimmed whitespace gtk-rs/gir#644

Created by: alatiera

gstreamer-rtsp-server-sys

This is because you're using GStreamer 1.12 and the gst-rtsp-server headers are not marking the version correctly for all the GstRTSPOnvif types. Bug in GStreamer, they should all get a Since: 1.14 marker.

Also gst-rtsp-server 1.14? Are the onvif headers not included by gst/rtsp-server/rtsp-server.h then? That would be a bug :)

They are, here is what they look like:

https://gist.github.com/alatiera/28957f9b77de165f63f3bc3cd73d5bda

gstreamer-rtsp-server-sys

This is because you're using GStreamer 1.12 and the gst-rtsp-server headers are not marking the version correctly for all the GstRTSPOnvif types. Bug in GStreamer, they should all get a Since: 1.14 marker.

Also gst-rtsp-server 1.14? Are the onvif headers not included by gst/rtsp-server/rtsp-server.h then? That would be a bug :)

They are, here is what they look like:

https://gist.github.com/alatiera/28957f9b77de165f63f3bc3cd73d5bda

The problem here is that rtsp-server.h is not including the onvif files. Yay! Looking at a solution, it's not so simple unfortunately :)

See https://bugzilla.gnome.org/show_bug.cgi?id=797361

gstreamer-rtsp-server-sys

This is because you're using GStreamer 1.12 and the gst-rtsp-server headers are not marking the version correctly for all the GstRTSPOnvif types. Bug in GStreamer, they should all get a Since: 1.14 marker.

Also gst-rtsp-server 1.14? Are the onvif headers not included by gst/rtsp-server/rtsp-server.h then? That would be a bug :)

They are, here is what they look like: https://gist.github.com/alatiera/28957f9b77de165f63f3bc3cd73d5bda

The problem here is that rtsp-server.h is not including the onvif files. Yay! Looking at a solution, it's not so simple unfortunately :)

See https://bugzilla.gnome.org/show_bug.cgi?id=797361

This one is fixed now, and all ONVIF types are also marked as since 1.14 too: https://cgit.freedesktop.org/gstreamer/gst-rtsp-server/commit/?id=d525000f6a1929fd4c3e5d3eb5988a64fbd2e43f

@alatiera this should probably be split into separate issues for the individual tasks and then we change this one to a tracker issue

mentioned in commit slomo/gstreamer-rs-sys@d5e992cb

mentioned in commit slomo/gstreamer-rs-sys@75cda423

The SDP and MPEG-TS issue are solved now !26 (merged)

gstreamer-sys:

Skip some C formatters, Merged.

@alatiera this is still a problem. While they are marked as not introspectable in the .gir file, we still generate bindings for them. That flag is ignored in gir because Rust is closer to C and almost all things marked as not introspectable can be handled by Rust.

I'll add ignores for these :)

I can make an MR ignoring them in the gir.toml if you don't beat me to it

@alatiera this should probably be split into separate issues for the individual tasks and then we change this one to a tracker issue

@slomo I thought this was already turned into a tracking issue, most of the things are upstream bugs no?

I can make an MR ignoring them in the gir.toml if you don't beat me to it

I have it locally with some other things already, thanks :)

@alatiera this should probably be split into separate issues for the individual tasks and then we change this one to a tracker issue @slomo I thought this was already turned into a tracking issue, most of the things are upstream bugs no?

True, but I was thinking of turning the description at the top into a task list with links to the relevant issues :) Want to do that or shall I?

Tests are broken

Child items ...

Activity

gstreamer-sys:

gstreamer-audio-sys

gstreamer-gl-sys

gstreamer-pbutils-sys

gstreamer-sdp-sys && gstreamer-mpegts-sys

gstreamer-rtsp-server-sys

gstreamer-rtsp-server-sys

gstreamer-rtsp-server-sys

gstreamer-sys:

Admin message

Admin message

Tests are broken

Activity

gstreamer-sys:

gstreamer-audio-sys

gstreamer-gl-sys

gstreamer-pbutils-sys

gstreamer-sdp-sys && gstreamer-mpegts-sys

gstreamer-rtsp-server-sys

gstreamer-rtsp-server-sys

gstreamer-rtsp-server-sys

gstreamer-sys: