Skip to content

rtpgccbwe: Resetting PTS/DTS to None breaks proper generation of RTCP and setting of NTP-64 header extension in rtpsession

See title. What's the rationale for doing this? Commenting out that code does not seem to have any negative effects and makes things work correctly

diff --git a/net/rtp/src/gcc/imp.rs b/net/rtp/src/gcc/imp.rs
index 84f6daa62..ce43237f9 100644
--- a/net/rtp/src/gcc/imp.rs
+++ b/net/rtp/src/gcc/imp.rs
@@ -1152,9 +1152,9 @@ impl ObjectSubclass for BandwidthEstimator {
                     || Err(gst::FlowError::Error),
                     |this| {
                         let mut state = this.state.lock().unwrap();
-                        let mutbuf = buffer.make_mut();
-                        mutbuf.set_pts(None);
-                        mutbuf.set_dts(None);
+                        //let mutbuf = buffer.make_mut();
+                        //mutbuf.set_pts(None);
+                        //mutbuf.set_dts(None);
                         state.buffers.push_front(buffer);
 
                         state.flow_return

CC @thiblahute

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information