Skip to content

audioparsers: add back segment clipping to parsers that have lost it

The pre_push_frame default clipping behaviour was introduced in 2010 with commit 30be0300 and modified with commit 4163969a in 2011, when most parsers didn't implement a pre_push_frame yet. Not having it meant that clipping was done by default. Those that did implement a pre_push_frame (flacparse and mpegaudioparse) at the time, had the flag adjusted as part of the 2011 refactor work.

All other parsers got a pre_push_frame vfunc implementation only in 2013, but seem to have forgot to keep the clipping behaviour, as was done automatically when a pre_push_frame implementation doesn't exist for the parser. aacparse lost it with commit 91d4abce in July 2013; the others in Dec 2013 as part of AUDIO_CODEC tag posting in commits 6f89b430, d2ab5199, 29f2cae1, 753d3c23 and 29278057.

Merge request reports