rtspsrc: no error on timeout

Sebastian Dröge @slomo said:

This is not so easy unfortunately. If media transport happens over TCP this of course makes sense, but otherwise (UDP) it's perfectly fine for the TCP connection to disappear. Media transport can continue via UDP and when new commands have to be sent a new TCP connection can be made.

Sebastian Dröge @slomo said:

Your patch is however working with the rtpbin timeouts, which should give a more accurate idea of the state of everything. So that's probably fine

Christian Lindeberg said:

So does that mean that the patch is fine? Or is there something more I need to do?

Sebastian, any more comments? If you are ok with this patch can you merge it ? BR /Patrick

Can you create a merge request for this patch?

I don't seem to be able to create a branch for the merge request as described in the documentation.

What do you do and what error do you get?

I see you have already created your personal fork on https://gitlab.freedesktop.org/christli/gst-plugins-good
add your personal repo to your local checkout with git remote add christli-gitlab git@gitlab.freedesktop.org:christli/gst-plugins-good.git
create a local branch with git checkout -b rtspsrc-no-error-on-timeout
push it to your personal fork with git push christli-gitlab rtspsrc-no-error-on-timeout (you can pass --dry-run for testing if you like)
if that works, you will get a link to create a merge request in the terminal output, or you can do it from the UI here: https://gitlab.freedesktop.org/christli/gst-plugins-good
if it doesn't work, what's the error? Did you add an ssh key to your gitlab account? (Click icon in top right corner -> Settings -> SSH Keys)

Thanks for the quick reply. Problem was I didn't realize that I had to fork.

Merge request created, !28 (closed).

After the discussions about the previous merge request I have created a new patch where the rtspsrc sends a custom message instead of an error message. Would this solution be ok?

0001-rtspsrc-send-GstRTSPSrcTimeout-message-on-timeout.patch