Skip to content

wavenc: fix tag and toc handling

Submitted by François Laignel @fengalin

Link to original bug (#791736)

Description

Created attachment 365692
Test cases

Wavenc uses local tag list and toc which are initialized when receiving tag/toc events. Upon EOS, the tag list and toc are written and wavenc decides what to do with the tags/toc set by the user using the TAG_SETTER/TOC_SETTER interfaces. The way it worked was such that the upstream tags/toc couldn't be reseted nor replaced.

The first commit introduces test cases, which show the faulty behaviours:

  • Receiving tags/toc from upstream.
  • User triggered tags/toc reset.
  • User triggered tags/toc replacement & tags append.

The third commit modifies tags/toc handling to use TAG_SETTER/TOC_SETTER for both upstream tags/toc and user defined tags/toc.

Patch 365692, "Test cases":
0001-wavenc-introduce-unit-test-to-show-issues-with-tags-.patch