rtpstorage: Keeps duplicate
I notice that rtpstorage keeps duplicate packet for reason I don't know. But some code seems to ensure that duplicates packet are well ordered in the storage.
- https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/blob/master/gst/rtp/rtpstoragestream.c#L47
- https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/blob/master/gst/rtp/rtpstoragestream.c#L129
That gives the impression that this might be on purpose. The reason this is of interest is that I'm about to reuse the storage in rtprtxsend, and started looking in the differences. The sender don't really expect duplicates, that would be quite surprising, but it does use a GSequence to speedup the lookup, as RTX storage tends to be much bigger.
Unless there is a good reason, I would drop the duplicates and so keep the storage small. Please complain if that's wrong.