rtpsession: avoid computing the sources multiple times in the same RTCP cycle
Submitted by Miguel París Díaz @mparisdiaz
Link to original bug (#790795)
Description
Created attachment 364343
rtpsession: avoid computing the sources multiple times in the same RTCP cycle
I come across a problem when RTCP is generated in an RtpSession with more than 1 internal&sender RtpSources that causes to add the same Report Blocks (RB) in each RTCP SR packet generated per each internal&sender RtpSource.
Whit this behavior:
- Bandwidth is wasted.
- fraction-lost value is wrong (except in the RBs of the first SR) due to its calculation is based in a previous state refreshed each time the RB is generated, which should only take place once per RTCP cycle, not per each internal&sender RtpSource in each RTCP cycle.
I am attaching a patch that fixes the issue and adds a test about it.
I think that the test could be improved using GstTestClock to crank RTCP thread.
Patch 364343, "rtpsession: avoid computing the sources multiple times in the same RTCP cycle":
0001-rtpsession-avoid-computing-the-sources-multiple-time.patch
Version: 1.8.3