Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-good gst-plugins-good
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 647
    • Issues 647
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 83
    • Merge requests 83
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-goodgst-plugins-good
  • Issues
  • #379

Closed
Open
Created Jun 09, 2017 by Bugzilla Migration User@bugzilla-migration

aacparse: wrong src caps profile for ADIF format aac clips

Submitted by Lyon

Link to original bug (#783583)

Description

Created attachment 353443
ADIF sample clip

When I am trying to play some ADIF aac clips with LC profile, and the src caps output from aacparse is Main profile.

Checked the aacparse, for ADIF stream, the object_type is got as:

aacparse->object_type = ((adif[6 + skip_size] & 0x01) << 1) |
((adif[7 + skip_size] & 0x80) >> 7)

and in spec this object_type definition as below:
index object_type
0 AAC Main
1 AAC LC
2 AAC SSR
3 AAC LTP

in aacparse to determine the profile, code as below:
switch (profile) {
case 1:
return "main";
case 2:
return "lc";
case 3:
return "ssr";
case 4:
return "ltp";
default:
break;
}

So actually here, aacparse->object_type need plus 1 to determine the profile (just as for ADTS stream.)

Attachment 353443, "ADIF sample clip":
AAC_LC_44kHz_64kbps_1_ADIF.aac

Version: 1.12.0

Assignee
Assign to
Time tracking