Skip to content

rtpsource: Stats contain useless SR fields for receiver sources

Submitted by Sebastian Dröge @slomo

Link to original bug (#746743)

Description

On the sender side, we currently have one rtpsource for sending, and then the N rtpsources for all the receivers.

The receiver rtpsource will then get the RRs at some point, and generate stats from it, which can be retrieved with the "stats" property. However these stats contain lots of fields that are always going to be 0: sr-*, packets/octets-received/sent, etc.

The sr-* fields look like they should contain the values from the last SR that was sent, but that one comes from a different rtpsource and the receiver rtpsource never sees that.

The packets/octets-received/sent fields would only contain a value if this was a source that sends data, or receives data. So never the receiver sources on the sender side.

Is this all intended as is? Should the SR at the sender side also go to all the receiver sources so that they can know the SR that resulted in the RRs that are received?