Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-good
gst-plugins-good
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 620
    • Issues 620
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 109
    • Merge Requests 109
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-goodgst-plugins-good
  • Issues
  • #160

Closed
Open
Opened Feb 20, 2015 by Bugzilla Migration User@bugzilla-migration

Some decoders need mp4's maximum sample size

Submitted by alf..@..al.com

Link to original bug (#744857)

Description

Created attachment 297396
Patch for qtdemux.c

HW decoders re-use input buffers and in some cases the size they use is too small because they try to minimize the (physical)memory resources employed when decoding. Therefore, some times it is needed to give them a good estimate of the maximum sample size to avoid decoding errors that happen when the input buffer size is smaller than the size of a sample.

This patch reads that information for iso mp4 containers, and complements the patch in bug 737599 (https://bugzilla.gnome.org/show_bug.cgi?id=737599), which did the same for avi files.

The size is determined using the sample size field in stsz atom if set or searching the maximum sample size in the sample size table field (stsz too) otherwise. This is similar to what is done in the AOSP project:

http://androidxref.com/4.4.2_r1/xref/frameworks/av/media/libstagefright/MPEG4Extractor.cpp#1353

(See http://goo.gl/sp3S8V for information on the mp4 stsz atom.)

We are using "max-input-size" cap in out androidmedia/hybris decoder

http://goo.gl/qoYLkm ,

as we found some videos produce artefacts for some HW decoders in mobile SoCs.

Patch 297396, "Patch for qtdemux.c":
0001-qtdemux-Set-maximum-sample-input-size-in-caps.patch

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gstreamer/gst-plugins-good#160