rtph264pay: don't include trailing zero bytes in SPS/PPS

Submitted by Philip Craig

Link to original bug (#732758)

Description

Created attachment 279940
Proposed fix

When using 4 byte start codes, rtph264pay includes the first byte of the following start code in the SPS/PPS. This results in the following warnings from h264parse:

0:00:00.019519088 3198 0x9b74cf0 DEBUG codecparsers_h264 gsth264parser.c:1721:gst_h264_parse_pps: parsing PPS
0:00:00.019526060 3198 0x9b74cf0 DEBUG codecparsers_h264 gsth264parser.c:230:nal_reader_read: Can not read 1 bits, bits in cache 0, Byte * 8 40, size in bits 40
0:00:00.019532976 3198 0x9b74cf0 WARN codecparsers_h264 gsth264parser.c:1819:gst_h264_parse_pps: failed to read SE
0:00:00.019537180 3198 0x9b74cf0 WARN codecparsers_h264 gsth264parser.c:1826:gst_h264_parse_pps: error parsing "Picture parameter set"

The attached patch fixes the problem in rtph264pay, but maybe h264parse should ignore trailing zeroes too.

Patch 279940, "Proposed fix":
rtph264pay-sps-pps-trailing-zero.patch

Version: 1.2.4