Part-of: <!1035>

Qi Hou authored Mar 01, 2021 and GStreamer Marge Bot committed Mar 03, 2021

Vp8/vp9 supported profiles/levels are listed in decoder sink caps, but
there is no parser for these two formats and the demuxers also don't have
these information. It causes negotiation fail between demuxers and decoder
when check caps "accept = gst_caps_is_subset (caps, template_caps);".
To fix this, need to remove profiles/levels for vp8/vp9 formats in decoder
sink caps.

Fix #854

Part-of: <!887>

Philipp Zabel authored Feb 24, 2021 and Philipp Zabel committed Feb 24, 2021

Negotiating v4l2h264dec ! v4l2h264enc transcoding pipelines fails in
case the encoder does not accept framerate=(fraction)0/1.
The acquired caps used for downstream negotiation are determined from
gst_v4l2_object_acquire_format(), which sets the GstVideoInfo::fps_n
and ::fps_d fields to 0.
To fix this, copy the frame rate from the sink side.

Part-of: <!882>

Part-of: <!778>

System frame numbers are supposed to be unique and correct drivers are
passing through timestamps without modification from the output/sink to the
capture/src side.

Part-of: <!778>

Víctor Manuel Jáquez Leal authored Aug 06, 2020 and GStreamer Marge Bot committed Aug 11, 2020

gst_v4l2_open() is called by gst_v4l2_device_provider_probe_device(),
where the GstV4l2Object is created without an associated GstElement.

If gst_v4l2_open() fails, it raises a bus message, but without an
element, a precondition check fails on
gst_element_message_full_with_details() generating a crash if running
with fatal-warnings debug mode.

GstV4l2Error is a helper to raise error bus messages when it is
appropiated. This patch changes the direct bus messages to this
helper, and the elements will actually send the error message.

Part-of: <!694>

Xavier Claessens authored May 26, 2020 and GStreamer Marge Bot committed Jul 03, 2020

Part-of: <!602>

gst_element_class_set_metadata is meant to only be used with
static or inlined strings, which isn't the case for the 2 elements
here resulting in use-after-free later on.

https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html?gi-language=c#gst_element_class_set_static_metadata

Part-of: <!622>

Nicolas Dufresne authored May 21, 2020 and GStreamer Marge Bot committed May 22, 2020

The levels and profiles probe function returned a dynamically allocated GValue
that was leaked. Simplify this by using a stack allocated GValue and a boolean
return value.

Part-of: <!599>

Nicolas Dufresne authored Apr 15, 2020 and Nicolas Dufresne committed Apr 15, 2020

This patch will now set the maximum of buffers to 32, allowing to grow the
pool for drivers that supports that and will respect the minimum buffers
reported by the driver. This was made to fix a stall with the virtio CODEC
driver.

Fixes #672

In commit e2ff8773 ("v4l2videodec: support orphaning") support for
orphaning the capture buffer pool was added when the format is
renegotiated. However, the commit forgot to check that a pool existed
before doing this. This is needed because it's possible for the format
to be renegotiated before a capture pool is allocated, which would
result in trying to orphan a NULL pool and lead to a NULL pointer
dereference.

Fix this by checking a pool exists first. If the pool doesn't exist,
there are no buffers to be reclaimed, so skip the allocation query in
that case.

Kevin Song authored Oct 11, 2019 and Nicolas Dufresne committed Oct 11, 2019

Backward playback will drain and flush every frame. Stop playback
when backward playback have race condition between exit thread and
streaming thread flush. Add one check to avoid it.

Fixes #639

Add support for V4L2 MPEG-2 decoders reporting supported profiles and
levels.

gst_pad_template_new() does not take ownership of the caps

Song Bing authored Jun 13, 2018 and Nicolas Dufresne committed Jun 24, 2019

Return right type for drain() function.

There used to be some profile/level support in encoders. This code was moved to
GstV4l2Codecs and is now also used for decoders. The caps templates for the
H.264, H.265, MPEG4, VP8 and VP9 encoders and decoders should now reflect the
profiles and levels advertised by the kernel.

The sink_event parent function may consume the event so we shouldn't use
it after having calling it.

Philipp Zabel authored Jan 24, 2019 and Nicolas Dufresne committed Apr 05, 2019

Recent kernels allow REQBUFS(0) on a queue that still has buffers in
use (mmapped or exported via dmabuf), orphaning all buffers on the queue.
If this is supported, the v4l2videodec element does not have to send a
drain request downstream.

If a different format is chosen, then these values are incorrect.

Song Bing authored Sep 13, 2018 and Nicolas Dufresne committed Sep 13, 2018

https://bugzilla.gnome.org/show_bug.cgi?id=771686

Nicolas Dufresne authored Sep 13, 2018 and Nicolas Dufresne committed Sep 13, 2018

This is to support Amlogic CODEC driver which does not provide a full
list of formats when the driver is initially opened. GStreamer does
not strictly need this full list initially, but only later, in order
to negotiate with downstream if multiple format can be selected.

With this change, we will no longer probe twice the device, since the
probed list can be directly used for negotation.

Ezequiel Garcia authored Sep 11, 2018 and Nicolas Dufresne committed Sep 13, 2018

Add a debug message right before waiting for the driver.
This is useful in order to debug drivers without a properly
implemented decoder or encoder stop command.

Ezequiel Garcia authored Sep 10, 2018 and Nicolas Dufresne committed Sep 13, 2018

The recently added vicodec (virtual codec) V4L driver
uses the Fast Walsh-Hadamard Transform for encoding
and decoding.

Add support for it.

In some cases, set_format() may get called twice before the output
format is set. Running an allocation query in this case is both not
needed and will cause assertion due tot he NULL caps.

Michael Tretter authored Jun 26, 2018 and Nicolas Dufresne committed Jun 27, 2018

gst_v4l2_buffer_pool_flush() executes streamoff for the output, but
streamoff->streamon for the capture of the decoder.
gst_v4l2_buffer_pool_streamon() on capture assumes that is able to
resurrect the buffers from the pool, but acquiring buffers fails if the
buffer pool is still flushing.

The decoder needs to stop flushing the pools before calling
gst_v4l2_buffer_pool_flush() to restart the v4l2 device. Otherwise
starting the decoding thread might fail, because there are no buffers in
the capture pool.

This fixes a regression that was introduced in 97985a33
("v4l2videodec: Add dynamic resolution change support").

https://bugzilla.gnome.org/show_bug.cgi?id=796681

Edward Hervey authored May 12, 2018 and Edward Hervey committed May 12, 2018

It's a decoder, not an encoder :)

https://bugzilla.gnome.org/show_bug.cgi?id=795941

Guillaume Desmottes authored Apr 13, 2018 and Nicolas Dufresne committed Apr 26, 2018

gst_v4l2_dup() will now take care of setting
v4l2capture->no_initial_format and keep_aspect instead of doing it
manually.

Fix a typo as keep_aspect was set twice on v4l2output but never on
v4l2capture.

https://bugzilla.gnome.org/show_bug.cgi?id=795028

Peter Seiderer authored Jan 12, 2018 and Nicolas Dufresne committed Jan 12, 2018

https://bugzilla.gnome.org/show_bug.cgi?id=791841

Peter Seiderer authored Jan 12, 2018 and Nicolas Dufresne committed Jan 12, 2018

https://bugzilla.gnome.org/show_bug.cgi?id=791841

This implements a "big hammer" reallocation method. We effectively
drain and stop both side of the decoder and restart. This though is
the most generic method. This change should enable on most drivers
adaptive streaming.

https://bugzilla.gnome.org/show_bug.cgi?id=752962

This way we can pass the pad name instead of the element for tracing
which helps identifying which v4l2object is used withing M2M element
like decoder, encoder and transform. For the reference, pads are name
<parent-name>:<pad-name>.

Philipp Zabel authored Dec 05, 2017 and Nicolas Dufresne committed Dec 06, 2017

Commit 1f31715c ("v4l2videodec: use visible size, not coded size,
for downstream negotiation filter") added support for removing the
padding obtained as the difference between width/height from G_FMT and
visible width/height from G_SELECTION from the probed caps obtained
via TRY_FMT.
This patch fixes the padding removal for drivers that only round up
height, but not width, to the padded frame size. This might happen
because horizontal padding can be handled by line stride (bytesperline),
but there is no such thing as plane stride in the V4L2 API for
single-buffer planar formats.

https://bugzilla.gnome.org/show_bug.cgi?id=791271

The purpose of being able to flush the buffer pool is only to
unlock any blocked operation. Doing streamoff/streamon had the
side effect of turning off and on the camera. As we do a flush_start
/ flush_stop sequence when shutting down, that would cause a really
quick sequence of streamoff/streamon/streamoff/close which was
causing some cameras to stop working.

https://bugzilla.gnome.org/show_bug.cgi?id=783945

This was missing, preventing the encoder and decoder to work
properly. This also adds support for camera that would produce
VP9 (if that exists).

Don't stop registering the other dynamic plugins if one registration
fails.

The library has started preventing a lot of interesting use cases,
like CREATE_BUFS, DMABuf, usage of TRY_FMT. As the libv4l2 is totally
inactive and not maintained, we decided to disable it. As a convenience
we added a run-time environment that let you enable it for testing.

  GST_V4L2_USE_LIBV4L2=1

This of course only works if you have enabled libv4l2 at build time.