• Tim-Philipp Müller's avatar
    pulse, speexenc, rtpgsmpay: don't use g_assert() for error handling · f3259353
    Tim-Philipp Müller authored
    Don't use g_assert() for error handling, even if they're highly unlikely.
    Either we *know* that something can't happen, in which case we
    should just not handle it, or we think something can happen, but it is
    very very unlikely that it will ever happen, in which case we should
    handle it like any other error instead of asserting.
    
    g_assert() is best left for conditions we have control of, like checking
    internal consistency of our code, not checking return values of external
    code.
    
    Fixes a bunch of warnings when compiling with -DG_DISABLE_ASSERT:
    gstrtpgsmpay.c: In function 'gst_rtp_gsm_pay_handle_buffer':
    gstrtpgsmpay.c:130:17: warning: variable 'rtpgsmpay' set but not used
    gstspeexenc.c: In function 'gst_speex_enc_encode':
    gstspeexenc.c:904:19: warning: variable 'written' set but not used
    pulsesink.c: In function 'gst_pulsesink_change_state':
    pulsesink.c:2725:9: warning: variable 'res' set but not used
    pulsesrc.c: In function 'gst_pulsesrc_change_state':
    pulsesrc.c:1253:7: warning: variable 'e' set but not used
    f3259353
pulsesrc.c 36.5 KB