Commit 39f4fda6 authored by Josep Torra's avatar Josep Torra Committed by Tim-Philipp Müller

rtcpbuffer: test for len instead of type

The function rtcp_packet_min_length() returns a length for each known type
and -1 for unknown types. This change fixes the test accordingly and silences
the following warning.

gstrtcpbuffer.c:567:12: error: comparison of constant -1 with expression of type 'GstRTCPType' is always false
      [-Werror,-Wtautological-constant-out-of-range-compare]
  if (type == -1)
parent e47bd848
......@@ -502,7 +502,7 @@ gst_rtcp_packet_move_to_next (GstRTCPPacket * packet)
g_return_val_if_fail (packet->rtcp != NULL, FALSE);
g_return_val_if_fail (packet->rtcp->map.flags & GST_MAP_READ, FALSE);
/* if we have a padding or invalid packet, it must be the last,
/* if we have a padding or invalid packet, it must be the last,
* return FALSE */
if (packet->type == GST_RTCP_TYPE_INVALID || packet->padding)
goto end;
......@@ -561,7 +561,7 @@ gst_rtcp_buffer_add_packet (GstRTCPBuffer * rtcp, GstRTCPType type,
* start a compount packet. Next we figure out if we have enough free space in
* the buffer to continue. */
len = rtcp_packet_min_length (type);
if (type == -1)
if (len == -1)
goto unknown_type;
if (packet->offset + len >= maxsize)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment