gst-plugins-base merge requestshttps://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests2019-01-16T09:47:12Zhttps://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/93meson: enable tests for orc code2019-01-16T09:47:12ZTim-Philipp Müllertim@centricular.commeson: enable tests for orc code1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/92gl: Only unbind buffers/vertex attrib arrays if we can't directly bind the ve...2020-06-16T00:06:13ZSebastian Drögegl: Only unbind buffers/vertex attrib arrays if we can't directly bind the vertex array to 0(updated title to match actual commit in the end)
That is, first disable the vertex arrays, then bind the buffers to 0 and
only then bind the vertex array to 0 instead of the other way around.
In the previous order older versions ...(updated title to match actual commit in the end)
That is, first disable the vertex arrays, then bind the buffers to 0 and
only then bind the vertex array to 0 instead of the other way around.
In the previous order older versions of the Intel GL driver caused
errors to be printed for every single call when disabling the vertex
arrays.
----
CC @ystreet1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/90pbutils: Add audio, base and video library to Requires line in the pkg-config...2020-06-23T14:09:33ZSebastian Drögepbutils: Add audio, base and video library to Requires line in the pkg-config fileWe use all those libraries internally and include headers from them in
the public headers.
And add the tag library to Requires.private as we use it internally and
it would be needed when doing static linking.
Fixes https://gitlab.freed...We use all those libraries internally and include headers from them in
the public headers.
And add the tag library to Requires.private as we use it internally and
it would be needed when doing static linking.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/5371.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/89glsinkbin: validate property in internal sink2020-06-23T14:09:33ZVíctor Manuel Jáquez Lealglsinkbin: validate property in internal sinkIt might be the case that glgsinkbin would try to set a property to
its internal sink which doesn't exist in it, leading to a glib's
warning. For example, when playsink sets 'force-aspect-ratio' property
and glsinkbin has, as internal si...It might be the case that glgsinkbin would try to set a property to
its internal sink which doesn't exist in it, leading to a glib's
warning. For example, when playsink sets 'force-aspect-ratio' property
and glsinkbin has, as internal sink, appsink, which doesn't handle
that property.
The patch validates the incoming property to forward to internal sink
if it exists in the internal sink and both properties has the same
type.1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/86video-converter: fix number of allocated lines2020-06-23T14:09:34ZNicolas Dufresnevideo-converter: fix number of allocated linesWe make an allocator for temporary lines and then use this for all
the steps in the conversion that can do in-place processing.
Keep track of the number of lines each step needs and use this to
allocate the right number of lines.
Previ...We make an allocator for temporary lines and then use this for all
the steps in the conversion that can do in-place processing.
Keep track of the number of lines each step needs and use this to
allocate the right number of lines.
Previously we would not always allocate enough lines and we would
end up with conversion errors as lines would be reused prematurely.
Fixes #350
Closes #3501.15.1Nicolas DufresneNicolas Dufresnehttps://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/85subparse: do not assert when failling to parse subrip time2020-06-23T14:09:34ZJordan Petridіssubparse: do not assert when failling to parse subrip timeIf a badly formatted was passed into `parse_subrip_time` it would
assert instead of exiting gracefully. This is problematic since
the input is provided by the user, and will trigger a crash.
Close #532If a badly formatted was passed into `parse_subrip_time` it would
assert instead of exiting gracefully. This is problematic since
the input is provided by the user, and will trigger a crash.
Close #5321.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/84videoscale: Negotiation fixes for fixed PAR2020-06-16T00:06:13ZJan Alexander Steffensvideoscale: Negotiation fixes for fixed PARThis is a set of fixes with the ultimate goal that scaling `width=854,height=480,pixel-aspect-ratio=1/1` into `width=[16,512,2],height=[16,512,2],pixel-aspect-ratio=1/1` works, without adding borders or distorting the image too much.
...This is a set of fixes with the ultimate goal that scaling `width=854,height=480,pixel-aspect-ratio=1/1` into `width=[16,512,2],height=[16,512,2],pixel-aspect-ratio=1/1` works, without adding borders or distorting the image too much.
**Depends on https://gitlab.freedesktop.org/gstreamer/gstreamer/merge_requests/67.**1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/82Fix build with more recent versions of MinGW2019-01-07T10:44:10ZAndoni Morales AlastrueyFix build with more recent versions of MinGW```
➜ _builddir git:(cerbero_build) ✗ ninja
[2/202] Compiling C object 'ext/gl/35d3624@@gstopengl@sha/gstgloverlay.c.obj'.
FAILED: ext/gl/35d3624@@gstopengl@sha/gstgloverlay.c.obj
x86_64-w64-mingw32-gcc -Iext/gl/35d3624@@gstopengl@...```
➜ _builddir git:(cerbero_build) ✗ ninja
[2/202] Compiling C object 'ext/gl/35d3624@@gstopengl@sha/gstgloverlay.c.obj'.
FAILED: ext/gl/35d3624@@gstopengl@sha/gstgloverlay.c.obj
x86_64-w64-mingw32-gcc -Iext/gl/35d3624@@gstopengl@sha -Iext/gl -I../ext/gl -I. -I../ -Igst-libs -I../gst-libs -Igst-libs/gst/gl -Igst-libs/gst/video -I/home/andoni/git/cerbero/build/dist/windows_x86_64/include/gstreamer-1.0 -I/home/andoni/git/cerbero/build/dist/windows_x86_64/include/glib-2.0 -I/home/andoni/git/cerbero/build/dist/windows_x86_64/lib/glib-2.0/include -I/home/andoni/git/cerbero/build/dist/windows_x86_64/include/orc-0.4 -I/home/andoni/git/cerbero/build/dist/windows_x86_64/include/graphene-1.0 -I/home/andoni/git/cerbero/build/dist/windows_x86_64/lib/graphene-1.0/include -I/home/andoni/git/cerbero/build/dist/windows_x86_64/include/libpng16 -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -O2 -g -fvisibility=hidden -fno-strict-aliasing -DG_DISABLE_DEPRECATED -Wmissing-declarations -Wredundant-decls -Wundef -Wwrite-strings -Wformat -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wvla -Wpointer-arith -Wmissing-prototypes -Wdeclaration-after-statement -mfpmath=sse -msse -msse2 -pthread -DHAVE_CONFIG_H -Wall -g -O2 -m64 -DWINVER=0x0600 -D_WIN32_WINNT=0x0600 -DGSTREAMER_GLIB_COCOA_NSAPPLICATION=1 -MD -MQ 'ext/gl/35d3624@@gstopengl@sha/gstgloverlay.c.obj' -MF 'ext/gl/35d3624@@gstopengl@sha/gstgloverlay.c.obj.d' -o 'ext/gl/35d3624@@gstopengl@sha/gstgloverlay.c.obj' -c ../ext/gl/gstgloverlay.c
In file included from /home/andoni/git/cerbero/build/dist/windows_x86_64/include/jpeglib.h:31,
from ../ext/gl/gstgloverlay.c:51:
/home/andoni/git/cerbero/build/dist/windows_x86_64/include/jmorecfg.h:242:13: error: conflicting types for 'boolean'
typedef int boolean;
^~~~~~~
In file included from /home/andoni/mingw/linux/w64/x86_64-w64-mingw32/sysroot/mingw/include/wtypes.h:8,
from /home/andoni/mingw/linux/w64/x86_64-w64-mingw32/sysroot/mingw/include/winscard.h:10,
from /home/andoni/mingw/linux/w64/x86_64-w64-mingw32/sysroot/mingw/include/windows.h:97,
from /home/andoni/git/cerbero/build/dist/windows_x86_64/include/GL/gl.h:13,
from ../gst-libs/gst/gl/gstglfuncs.h:68,
from ../ext/gl/gstgloverlay.h:25,
from ../ext/gl/gstgloverlay.c:42:
/home/andoni/mingw/linux/w64/x86_64-w64-mingw32/sysroot/mingw/include/rpcndr.h:65:25: note: previous declaration of 'boolean' was here
typedef unsigned char boolean;
^~~~~~~
[4/202] Compiling C object 'ext/ogg/7247bfe@@gstogg@sha/gstoggdemux.c.obj'.
ninja: build stopped: subcommand failed.
```1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/81rtcpbuffer: fix function guards with side effects2018-12-30T22:25:53ZTim-Philipp Müllertim@centricular.comrtcpbuffer: fix function guards with side effectsCode in g_return_*() must not have side effects, as it
might be compiled out if -DG_DISABLE_CHECKS is used, in
which case we would read garbage off the stack.Code in g_return_*() must not have side effects, as it
might be compiled out if -DG_DISABLE_CHECKS is used, in
which case we would read garbage off the stack.1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/80tests: Enable more tests on Windows2018-12-31T00:02:53ZSeungha Yangseungha@centricular.comtests: Enable more tests on WindowsEnable libs_rtp, libs_video and elements_compositorEnable libs_rtp, libs_video and elements_compositor1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/79gl: Fix some type conversion warnings with MSVC2020-06-16T00:06:12ZSeungha Yangseungha@centricular.comgl: Fix some type conversion warnings with MSVCMSVC complained about implicit conversion between GstGLFormat* and guint*MSVC complained about implicit conversion between GstGLFormat* and guint*1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/78audiotestsrc: Improvements to the "ticks" wave2019-01-10T17:24:46ZVasil Kolevaudiotestsrc: Improvements to the "ticks" wave(this is actually the work of Carlos Rafael Giani, coming from
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/305)
The ticks waveform can be useful for audio synchronization diagnostics
and other cases where the ti...(this is actually the work of Carlos Rafael Giani, coming from
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/305)
The ticks waveform can be useful for audio synchronization diagnostics
and other cases where the time offset between waveforms is important.
However, in its current form, it is too limited, and has problems with
discontinuities, which result in severe artifacts when this waveform
is output by a DAC.
This patch fixes some discontinuities and considerably expand the ticks
waveform's flexibility. They also introduce the notion of a "marker tick";
every Nth tick can have a different amplitude (usually one that is larger
than the others). This is useful for combining frequent oscilloscope
triggering with large time offset detection. For example, without marker
ticks, the tick intervals must not be too small, otherwise the maximum time
offset that can be unambiguously detected is quite small (for example, if
the interval is 50ms, then no time offset larger than 25ms can be
unambiguously recognized). If the tick intervals are too far apart, then
no sudden changes can be clearly observed, since the oscilloscope is not
updated quickly enough. But with marker ticks, this is not an issue: If
there's for example a tick every 100 ms, then the oscilloscope can be
triggered every 100 ms. And, if every 20th tick is a marker tick, then
time offsets of up to 1 second can be discovered, even though the time
between ticks is 100 ms.
The patch also applies some minor cleanup to the audiotestsrc documentation.1.15.1Tim-Philipp Müllertim@centricular.comTim-Philipp Müllertim@centricular.comhttps://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/76Move videoaggregator, compositor, and gl mixer elements from -bad to -base2018-12-28T13:57:44ZTim-Philipp Müllertim@centricular.comMove videoaggregator, compositor, and gl mixer elements from -bad to -base1.15.1Tim-Philipp Müllertim@centricular.comTim-Philipp Müllertim@centricular.comhttps://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/74examples/gl/gtk: Fix build on macOS2018-12-27T14:50:38ZPhilippe Normandexamples/gl/gtk: Fix build on macOSThe gdkquartz.h include pulls into Apple Obj-C frameworks so the compiler needs
to handle the gstgtkhelper library as such.
Fixes #518The gdkquartz.h include pulls into Apple Obj-C frameworks so the compiler needs
to handle the gstgtkhelper library as such.
Fixes #5181.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/73typefindfunctions: Extend MCC typefinder to also cover version 2.02020-06-16T00:06:11ZSebastian Drögetypefindfunctions: Extend MCC typefinder to also cover version 2.0Both versions are basically the same, but version 2.0 also allows
60000/1001 as framerate and allows to specify the field and line number
for each payload.
Put the major version into the caps so that elements can limit via caps
negotiat...Both versions are basically the same, but version 2.0 also allows
60000/1001 as framerate and allows to specify the field and line number
for each payload.
Put the major version into the caps so that elements can limit via caps
negotiation which versions they can support.
----
CC @alatiera1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/72typefind: Add SCC and MCC files support2020-06-16T00:06:09ZJordan Petridіstypefind: Add SCC and MCC files support1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/71examples/gl: Cocoa example Meson build definitions2020-06-16T00:06:10ZPhilippe Normandexamples/gl: Cocoa example Meson build definitions1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/70Misc fixes detected with scan-build2020-06-16T00:06:06ZEdward HerveyMisc fixes detected with scan-builddescription/rationale of the fixes are in the commit messagesdescription/rationale of the fixes are in the commit messages1.15.1Sebastian DrögeSebastian Drögehttps://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/69rtp: fix g-i warnings2018-12-16T23:53:54ZTim-Philipp Müllertim@centricular.comrtp: fix g-i warningsUse same variable name in function declaration as in function definition and gtk-doc/g-i blurb.
```
gstrtpmeta.c:36: Warning: GstRtp: gst_buffer_add_rtp_source_meta: unknown parameter 'buffer' in documentation comment, should be 'buf'
g...Use same variable name in function declaration as in function definition and gtk-doc/g-i blurb.
```
gstrtpmeta.c:36: Warning: GstRtp: gst_buffer_add_rtp_source_meta: unknown parameter 'buffer' in documentation comment, should be 'buf'
gstrtpmeta.c:80: Warning: GstRtp: gst_buffer_get_rtp_source_meta: unknown parameter 'buffer' in documentation comment, should be 'buf'
```1.15.1https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/68audioconvert: disable passthrough_on_same_caps2020-06-16T00:06:07ZMathieu Duponchelleaudioconvert: disable passthrough_on_same_capsNow that audioconvert exposes a mix-matrix property, input and
output caps may be equal, but the mix-matrix still needs to be
applied.
Fixes #521Now that audioconvert exposes a mix-matrix property, input and
output caps may be equal, but the mix-matrix still needs to be
applied.
Fixes #5211.15.1