Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gst-plugins-base gst-plugins-base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 642
    • Issues 642
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 79
    • Merge requests 79
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • GStreamerGStreamer
  • gst-plugins-basegst-plugins-base
  • Issues
  • #767
Closed
Open
Issue created Jun 07, 2020 by Sebastian Dröge@slomo🍵Owner0 of 3 checklist items completed0/3 checklist items

Move GstPlanarAudioAdapter to -base

CC @gkiagia

Open questions/issues (please add more)

  • Should it also work for interleaved audio? IMHO yes but it currently doesn't, we would need a different name then (GstAudioAdapter)
  • GstMapFlags usage is weird: if no write-mapping is requested this does only shallow copies of buffers. But always doing that would simply cause the deep-copy of the memory to happen on write-mapping so that's exactly the same overall. What is the rationale here?
  • Use a GQueue or other more optimal data structure (g_slist_append() and counting list length manually is not great)

Otherwise looks fine to me at least.

Assignee
Assign to
Time tracking