Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-base
gst-plugins-base
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 624
    • Issues 624
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 101
    • Merge Requests 101
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GStreamer
  • gst-plugins-basegst-plugins-base
  • Issues
  • #631

Closed
Open
Opened Jun 19, 2019 by David Ing@ding

log spam: "can't find exact taps"

I have been seeing a lot of logspam from a couple of warnings in the code-base: GST_WARNING ("can't find exact taps");

One is in audio-resampler.c One is in video-scaler.c.

According to @slomo these are "harmless and shouldn't really be a warning". I'm not sure what the correct log level should be because I don't really understand what a "tap" is.

Another issue is that the documentation doesn't really define what a "tap" is, and perhaps the only way to figure it out is a deep dive into the code (which I have not done). (I took a quick glance and it wasn't clear.)

Someone should define "tap" in the documentation (code comments). Here are the relevant entities in the code.

  • GST_AUDIO_RESAMPLER_OPT_N_TAPS
  • GST_VIDEO_RESAMPLER_OPT_MAX_TAPS
  • GstVideoResampler.n_taps
  • GstVideoResampler.taps
  • GST_VIDEO_RESAMPLER_FLAG_HALF_TAPS
  • gst_video_scaler_get_max_taps(...)
  • gst_video_scaler_new(..., n_taps, ...)
  • GST_VIDEO_CONVERTER_OPT_RESAMPLER_TAPS
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gstreamer/gst-plugins-base#631