Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-base
gst-plugins-base
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 632
    • Issues 632
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 101
    • Merge Requests 101
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-basegst-plugins-base
  • Issues
  • #502

Closed
Open
Opened Nov 04, 2018 by Snir Sheriber@snir

glimagesink: GstVideoOverlay interface sometimes fail to set a window handle

When utilizing the video overlay interface with glimagesink it sometimes opens a new "OpenGL Renderer" window although i set the handle to an valid & existing gdk window (x11)

After looking into the code it seems the overlay interface _set_handle function points to gst_glimage_sink_set_window_handle but the function that actually sets the handle is gst_gl_window_set_window_handle which is called by the prepare cb of the sink base class and this may be called too late (expose event sometimes occurs before that and this is result in a mapping of a newly created window although application has called overlay_set_handle with an existing one).

For example the attached diff seems to fix it but possibly it is not correct, (also if someone can shed more light on this part of the code or on how to fix it please do). diff.diff

Edited Nov 04, 2018 by Sebastian Dröge
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gstreamer/gst-plugins-base#502