Commit 8a88e5c1 authored by Tim-Philipp Müller's avatar Tim-Philipp Müller 🐠
Browse files

tag: id3v2: fix frame size check and potential invalid reads

Check the right variable when checking if there's
enough data left to read the frame size.

Closes #876

Part-of: <!1066>
parent 42b4ed92
Pipeline #284198 waiting for manual action with stages
in 1 minute and 5 seconds
This commit is part of merge request !1066. Comments created here will be created in the context of that merge request.
......@@ -109,7 +109,7 @@ id3v2_parse_frame (ID3TagsWorking * work)
if (work->frame_flags & (ID3V2_FRAME_FORMAT_COMPRESSION |
ID3V2_FRAME_FORMAT_DATA_LENGTH_INDICATOR)) {
if (work->hdr.frame_data_size <= 4)
if (frame_data_size <= 4)
return FALSE;
if (ID3V2_VER_MAJOR (work->hdr.version) == 3) {
work->parse_size = GST_READ_UINT32_BE (frame_data);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment