Skip to content

msdk: Allow video and system memory share among buffers

Seungha Yang requested to merge seungha.yang/gst-plugins-bad:msdk-fix into master
msdk: Remove all DMABuf caps features on Windows

Add new macro for sink/src pad template to ensure no DMABuf caps
features are exposed on Windows. Some DMABuf caps features
were not handled by the commit 9ec62418c31cab4072bf173f279234e36eeec596
msdkdec: Do not use video memory on Windows

Like msdkenc, do not use video memory by default on Windows.
msdk: Allow video and system memory share among buffers

gst_buffer_make_writable() requires exclusive reference to the
GstMemory so the _make_writable() for the msdk buffer will result
to fallback system memory copy, because the msdk memory were initialized
with GST_MEMORY_FLAG_NO_SHARE flag.

Note that, disable sharing GstMemory brings high overhead but actually
the msdk memory objects can be shared over multiple buffers.
If the memory is not shareable, newly added GstAllocator::mem_copy will
create copied msdk memory.

Fixes: #1061 (closed)

Edited by Seungha Yang

Merge request reports