Fixes for the FluidSynth plugin (!1026) · Merge requests · GStreamer / gst-plugins-bad · GitLab

Snippets Groups Projects

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

The migration is almost done, at least the rest should happen in the background. There are still a few technical difference between the old cluster and the new ones, and they are summarized in this issue. Please pay attention to the TL:DR at the end of the comment.

Merged Jan Alexander Steffens requested to merge heftig/gst-plugins-bad:fluidfixes into master 5 years ago

fluiddec: Avoid deprecated fluid_synth_set_sample_rate
This function is used to change the rate at runtime, which has issues: https://github.com/FluidSynth/fluidsynth/issues/585
Use the settings key instead (which already defaults to 44100, but I did test other rates).

fluiddec: Keep fluidsynth from probing audio drivers
It might cause problems and we don't need the drivers anyway. This also avoids a bunch of stderr spam from the drivers.

Activity

Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@0b1dfc92 5 years ago

mentioned in commit heftig/gst-plugins-bad@0b1dfc92
Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@4b077a5f 5 years ago

mentioned in commit heftig/gst-plugins-bad@4b077a5f
Jan Alexander Steffens added 2 commits 5 years ago
added 2 commits

0b1dfc92 - fluiddec: Avoid deprecated fluid_synth_set_sample_rate

4b077a5f - fluiddec: Keep fluidsynth from probing audio drivers

Compare with previous version
Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@391a0437 5 years ago

mentioned in commit heftig/gst-plugins-bad@391a0437
Jan Alexander Steffens mentioned in commit heftig/gst-plugins-bad@173381e6 5 years ago

mentioned in commit heftig/gst-plugins-bad@173381e6
Jan Alexander Steffens added 3 commits 5 years ago
added 3 commits

5b8ff98f - 1 commit from branch gstreamer:master

173381e6 - fluiddec: Avoid deprecated fluid_synth_set_sample_rate

391a0437 - fluiddec: Keep fluidsynth from probing audio drivers

Compare with previous version
Jan Schmidt @thaytan started a thread on the diff 5 years ago

Resolved 5 years ago by Jan Schmidt
Last reply by Jan Schmidt 5 years ago

Jan Alexander Steffens mentioned in commit 5 years ago

mentioned in commit heftig/gst-plugins-bad@5d231f9b

Jan Alexander Steffens mentioned in commit 5 years ago

mentioned in commit heftig/gst-plugins-bad@0c1e24de

Jan Alexander Steffens mentioned in commit 5 years ago

mentioned in commit heftig/gst-plugins-bad@8ca21bfd

Jan Alexander Steffens added 23 commits 5 years ago

added 23 commits

391a0437...4ffa6350 - 20 commits from branch gstreamer:master
5d231f9b - fluiddec: Avoid deprecated fluid_synth_set_sample_rate
8ca21bfd - fluiddec: Keep fluidsynth from probing audio drivers
0c1e24de - fluiddec: Move logging init into plugin_init

Compare with previous version

Toggle commit list

Jan Alexander Steffens resolved all threads 5 years ago

resolved all threads

Jan Schmidt resolved all threads 5 years ago

resolved all threads

Jan Schmidt assigned to @thaytan 5 years ago

assigned to @thaytan

Jan Schmidt assigned to @gstreamer-merge-bot and unassigned @thaytan 5 years ago

assigned to @gstreamer-merge-bot and unassigned @thaytan

Jan Alexander Steffens mentioned in commit 5 years ago

mentioned in commit heftig/gst-plugins-bad@9aa12399

Jan Alexander Steffens mentioned in commit 5 years ago

mentioned in commit heftig/gst-plugins-bad@c35e80dc

Jan Alexander Steffens mentioned in commit 5 years ago

mentioned in commit heftig/gst-plugins-bad@e2cefdd6

GStreamer Marge Bot added 4 commits 5 years ago

added 4 commits

3df3c3c5 - 1 commit from branch gstreamer:master
c35e80dc - fluiddec: Avoid deprecated fluid_synth_set_sample_rate
9aa12399 - fluiddec: Keep fluidsynth from probing audio drivers
e2cefdd6 - fluiddec: Move logging init into plugin_init

Compare with previous version

Toggle commit list

GStreamer Marge Bot merged 5 years ago

merged

Please register or sign in to reply