Frei0r plugins expose incorrectly split properties for RGB stuff
Submitted by Jeff Fortin Tam @nekohayo
Link to original bug (#695884)
Description
Created attachment 238937
screenshot
gst-inspect-1.0 frei0r-filter-white-balance
Yields the following element properties besides name, parent, qos:
neutral-color-r : Choose a color from the source image that should be white.
flags: readable, writable, controllable
Float. Range: 0 - 1 Default: 1
neutral-color-g : Choose a color from the source image that should be white.
flags: readable, writable, controllable
Float. Range: 0 - 1 Default: 1
neutral-color-b : Choose a color from the source image that should be white.
flags: readable, writable, controllable
Float. Range: 0 - 1 Default: 1
green-tint : Adjust the level of green.
flags: readable, writable, controllable
Double. Range: 0 - 1 Default: 1.2
Looking at frei0r's balanc0r.c, I see only one single "neutral-color" property. I can guess that GStreamer somehow split that property into three.
The problem is that the description incorrectly stays the same for all three virtual properties, so when you display them in a GUI like pitivi, the descriptions are all identical.
What's worse however is that in pitivi (and this is both in 0.10 and 1.x git), the property "names" that are exposed to us by gstreamer are somehow incorrect, as the attached screenshot demonstrates: instead of "Neutral R color value", "Neutral G color value", "Neutral B color value", you get only "Neutral Color:" shown twice and one "Neutral Color-R:"
Not only that, the actual value prop boundaries don't seem to make sense. If my understanding of the gst inspect output above is correct, it goes from 0.0 to 1.0... but RGB would be 0 to 255 each, no?
This is not necessarily specific to frei0r's white balance filter, various other frei0r filters seem to be affected in similar ways, especially when it comes to the naming of human-readable properties names, or descriptions being missing. Is there a central place where you are overriding frei0r's strings somewhere in gstreamer?
Attachment 238937, "screenshot":
