h264parse: Alignment of input caps no longer set to a default value
Submitted by Will
Link to original bug (#782778)
Description
In the following change the 'handling of input caps corner cases for the h264parse element" was tidied up.
Although not sure, I believe that there may have been an unintended behavioural change with the above submission.
Prior to the submission, when the stream format was not specified in the input caps the local 'format' variable was assigned a default value of GST_H264_PARSE_FORMAT_BYTE and the local 'alignment' variable was assigned a default value of GST_H264_PARSE_ALIGN_AU.
After the submission when the stream format was not specified in the input caps the local 'format' variable was assigned a default value of GST_H264_PARSE_FORMAT_BYTE and the local 'alignment' variable was left unchanged.
When 'format' is given a default value, should alignement be given a value that is appropriate for the chosen default stream format? Not doing so, can result in unexpected behaviour of the gst_h264_parse_negotiate() method that gst_h264_parse_set_caps() calls